Skip to content

bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros #20435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 5 commits into from
May 29, 2020
Merged

bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros #20435

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6ffd2e
Fix failure of _Py_dg_dtoa to remove trailing zeros
mdickinson May 26, 2020
589da50
Add regression test and news entry
mdickinson May 26, 2020
e9a13a1
Add explanation about why it's safe to strip trailing zeros
mdickinson May 26, 2020
5773e56
Make code safer, clean up comments, add change note at top of file
mdickinson May 27, 2020
556f7dd
Nitpick: avoid implicit int-to-float conversion in tests
mdickinson May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Nitpick: avoid implicit int-to-float conversion in tests
  • Loading branch information
@mdickinson
mdickinson committed May 27, 2020
commit 556f7dd89b21a3dca868aed4148c17db3093152e
12 changes: 6 additions & 6 deletions Lib/test/test_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,14 +486,14 @@ def test_precision_c_limits(self):

def test_g_format_has_no_trailing_zeros(self):
# regression test for bugs.python.org/issue40780
self.assertEqual("%.3g" % 1505, "1.5e+03")
self.assertEqual("%#.3g" % 1505, "1.50e+03")
self.assertEqual("%.3g" % 1505.0, "1.5e+03")
self.assertEqual("%#.3g" % 1505.0, "1.50e+03")

self.assertEqual(format(1505, ".3g"), "1.5e+03")
self.assertEqual(format(1505, "#.3g"), "1.50e+03")
self.assertEqual(format(1505.0, ".3g"), "1.5e+03")
self.assertEqual(format(1505.0, "#.3g"), "1.50e+03")

self.assertEqual(format(12300050, ".6g"), "1.23e+07")
self.assertEqual(format(12300050, "#.6g"), "1.23000e+07")
self.assertEqual(format(12300050.0, ".6g"), "1.23e+07")
self.assertEqual(format(12300050.0, "#.6g"), "1.23000e+07")


if __name__ == "__main__":
Expand Down