Skip to content

bpo-40334: Correctly identify invalid target in assignment errors #20076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 9 commits into from
May 15, 2020
Merged

bpo-40334: Correctly identify invalid target in assignment errors #20076

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
445c7fd
bpo-40334: Correctly identify invalid target in assignment errors
pablogsal May 13, 2020
d385c29
Update Grammar/python.gram
pablogsal May 13, 2020
b596bba
Deduplicate code with macro
pablogsal May 14, 2020
4f2cb72
Fix error for augassign
pablogsal May 14, 2020
c74ecce
Address Lysandros's feedback
pablogsal May 15, 2020
6d1d63c
Add quotes around the node type
pablogsal May 15, 2020
00a2205
Update test_dictcomps, test_genexps and test_generators
pablogsal May 15, 2020
349ea59
Update some tests to the new errors
pablogsal May 15, 2020
6a5c4ed
Add a comment explaining why we only visit Tuples and Lists
pablogsal May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Grammar/python.gram 
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
  • Loading branch information
@pablogsal @lysnikolaou
pablogsal and lysnikolaou committed May 14, 2020
commit d385c2928d57cac20052b71261278a46487d4b2c
12 changes: 11 additions & 1 deletion Grammar/python.gram
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,11 +640,21 @@ invalid_assignment:
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "only single target (not tuple) can be annotated") }
| a=expression ':' expression ['=' annotated_rhs] {
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "illegal target for annotation") }
| a=expression ('=' | augassign) (yield_expr | star_expressions) {
| a=star_expressions '=' (yield_expr | star_expressions) {
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(
_PyPegen_get_invalid_target(a),
"cannot assign to %s", _PyPegen_get_expr_name(_PyPegen_get_invalid_target(a))
)}
| a=expression augassign (yield_expr | star_expressions) {
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(
_PyPegen_get_invalid_target(a),
"cannot assign to %s", _PyPegen_get_expr_name(_PyPegen_get_invalid_target(a))
)}
Comment thread
pablogsal marked this conversation as resolved.
Outdated
| a=star_expressions augassign (yield_expr | star_expressions) {
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(
a,
"illegal expression for augmented assignment"
)}
invalid_block:
| NEWLINE !INDENT { RAISE_INDENTATION_ERROR("expected an indented block") }
invalid_comprehension:
Expand Down
16 changes: 0 additions & 16 deletions Lib/test/test_foo.py
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions Lib/test/test_syntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,14 @@
Traceback (most recent call last):
SyntaxError: cannot assign to operator

>>> [a, b[1], c + 1] = [1, 2, 3]
Traceback (most recent call last):
SyntaxError: cannot assign to operator

>>> [a, b.c.d, c + 1] = [1, 2, 3]
Traceback (most recent call last):
SyntaxError: cannot assign to operator

>>> a if 1 else b = 1
Traceback (most recent call last):
SyntaxError: cannot assign to conditional expression
Expand Down
Loading