Skip to content

bpo-40334: produce specialised errors for del #19911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 12 commits into from
May 11, 2020
Merged

bpo-40334: produce specialised errors for del #19911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c2219f7
pegen: produce specialised messages for del
May 4, 2020
343ccb5
pegen: further improve del error messages
May 4, 2020
4029ee5
del: add more tests
May 4, 2020
f6b219f
pegen: fix del error messages for binary ops and others
May 5, 2020
9b11bed
pegen: add doctest back in
May 5, 2020
8b4ead5
grammar: reorder and add comment
May 5, 2020
fa21224
del: add even more tests
May 5, 2020
d101ac1
pegen: fix more del test cases
May 5, 2020
850ba88
grammar: reuse del_target_end in invalid_del_target
May 5, 2020
461fe85
grammar: add ENDMARKER to del_target_end
May 5, 2020
d462df9
Revert "grammar: add ENDMARKER to del_target_end"
May 11, 2020
566745e
make regen-pegen
May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
del: add even more tests
  • Loading branch information
hauntsaninja
hauntsaninja committed May 11, 2020
commit fa2122400ba11ec25e9eca26e5c210544325479c
1 change: 1 addition & 0 deletions Lib/test/test_grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,7 @@ def test_del_stmt(self):
del x
del y,
del (z)
del ()

a, b, c, d, e, f, g = "abcdefg"
del a, (b, c), (d, (e, f))
Expand Down
8 changes: 7 additions & 1 deletion Lib/test/test_syntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ def _check_error(self, code, errtext,
self.fail("SyntaxError is not a %s" % subclass.__name__)
mo = re.search(errtext, str(err))
if mo is None:
self.fail("SyntaxError did not contain '%r'" % (errtext,))
self.fail("SyntaxError did not contain %r" % (errtext,))
self.assertEqual(err.filename, filename)
if lineno is not None:
self.assertEqual(err.lineno, lineno)
Expand All @@ -677,6 +677,7 @@ def test_assign_call(self):
self._check_error("f() = 1", "assign")

def test_assign_del(self):
self._check_error("del (,)", "invalid syntax")
self._check_error("del 1", "delete literal")
self._check_error("del (1, 2)", "delete literal")
self._check_error("del None", "delete None")
Expand All @@ -690,12 +691,17 @@ def test_assign_del(self):
self._check_error("del a[0]()", "delete function call")
self._check_error("del x, f()", "delete function call")
self._check_error("del f(), x", "delete function call")
self._check_error("del [a, b, ((c), (d,), e.f())]", "delete function call")
self._check_error("del (a if True else b)", "delete conditional")
self._check_error("del +a", "delete operator")
self._check_error("del a, +b", "delete operator")
self._check_error("del a + b", "delete operator")
self._check_error("del (a + b, c)", "delete operator")
self._check_error("del (c[0], a + b)", "delete operator")
self._check_error("del a.b.c + 2", "delete operator")
self._check_error("del a.b.c[0] + 2", "delete operator")
self._check_error("del (a, b, (c, d.e.f + 2))", "delete operator")
self._check_error("del [a, b, (c, d.e.f[0] + 2)]", "delete operator")
self._check_error("del (a := 5)", "delete named expression")
# We don't have a special message for this, but make sure we don't
# report "cannot delete name"
Expand Down