Skip to content

bpo-40355: ast.literal_eval rejects malformed Dict nodes #19868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 5 commits into from
May 5, 2020
Merged

bpo-40355: ast.literal_eval rejects malformed Dict nodes #19868

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36eb5b8
Fix literal_eval and add tests
curtisbucher May 2, 2020
2c72460
Update ast.py
curtisbucher May 3, 2020
3e68c2e
Update Misc/NEWS.d/next/Library/2020-05-02-14-24-48.bpo-40355.xTujaB.rst
curtisbucher May 5, 2020
2427ed2
Update ast.py and test_ast.py
curtisbucher May 5, 2020
bc9274f
Merge branch 'astliteraleval' of https://github.com/curtisbucher/cpyt…
curtisbucher May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Misc/NEWS.d/next/Library/2020-05-02-14-24-48.bpo-40355.xTujaB.rst 
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
  • Loading branch information
@curtisbucher @pablogsal
curtisbucher and pablogsal authored May 5, 2020
commit 3e68c2ed8dc871c356a176b1737fa40b07a0dcb2
4 changes: 2 additions & 2 deletions Misc/NEWS.d/next/Library/2020-05-02-14-24-48.bpo-40355.xTujaB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Fixed case where malformed :class:`ast.Dict` nodes could have keys or values
thrown away by :func:`ast.literal_eval`. Patch by Curtis Bucher.
Improve error reporting in :func:`ast.literal_eval` in the presence of malformed :class:`ast.Dict`
nodes instead of silently ignoring any non-conforming elements. Patch by Curtis Bucher.