Skip to content

bpo-35569: Expose RFC 3542 IPv6 socket options on macOS #19526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ned-deily merged 4 commits into from
May 17, 2020
Merged

bpo-35569: Expose RFC 3542 IPv6 socket options on macOS #19526

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae17650
bpo-35569: Expose RFC 3542 socket options on macOS
Feb 29, 2020
fe71bb7
bpo-35569: Add unit tests
Apr 13, 2020
ebfde1f
Use `socket_helper` (see PR #19603)
Apr 27, 2020
f6bda5d
Only define __APPLE_USE_RFC_3542 when building socket lib
Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-35569: Expose RFC 3542 socket options on macOS 
From macOS SDK netinet6/in6.h:
RFC 3542 define the following socket options in a manner incompatible
with RFC 2292:
  IPV6_PKTINFO
  IPV6_HOPLIMIT
  IPV6_NEXTHOP
  IPV6_HOPOPTS
  IPV6_DSTOPTS
  IPV6_RTHDR

To use the new IPv6 Sockets options introduced by RFC 3542
the constant __APPLE_USE_RFC_3542 must be defined before
including <netinet/in.h>

[...]

Note that eventually RFC 3542 is going to be the
default and RFC 2292 will be obsolete.
  • Loading branch information
Erlend E. Aasland
Erlend E. Aasland committed Apr 27, 2020
commit ae176509145ba1db766e30aac55e1ef62ff902aa
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/macOS/2020-04-15-00-02-47.bpo-35569.02_1MV.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Expose RFC 3542 IPv6 socket options.
3 changes: 3 additions & 0 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7421,6 +7421,9 @@ $as_echo "$ac_cv_enable_visibility" >&6; }
;;

Darwin*)
# Issue #35569: Expose the RFC 3542 socket options.
CFLAGS="-D__APPLE_USE_RFC_3542 ${CFLAGS}"

# -Wno-long-double, -no-cpp-precomp, and -mno-fused-madd
# used to be here, but non-Apple gcc doesn't accept them.
if test "${CC}" = gcc
Expand Down
3 changes: 3 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1844,6 +1844,9 @@ yes)
;;

Darwin*)
# Issue #35569: Expose the RFC 3542 socket options.
CFLAGS="-D__APPLE_USE_RFC_3542 ${CFLAGS}"
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated

# -Wno-long-double, -no-cpp-precomp, and -mno-fused-madd
# used to be here, but non-Apple gcc doesn't accept them.
if test "${CC}" = gcc
Expand Down