Skip to content

bpo-40105: Truncating file if opened in append mode. #19337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taleinat merged 7 commits into from
Sep 28, 2020
Merged

bpo-40105: Truncating file if opened in append mode. #19337

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e76411f
Truncating file if opened in append mode.
mzr Apr 3, 2020
c311362
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 3, 2020
4f8d7cb
fix news dos
mzr Apr 3, 2020
a93382e
check whether file whether zipfile was truncated when appending short…
mzr Sep 26, 2020
bdfda09
Merge branch 'master' into zipfile-shorten-comment-test-fix
mzr Sep 28, 2020
55d3b46
delete unnecessary whitespace change
mzr Sep 28, 2020
198b93b
slightly reword NEWS entry
taleinat Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check whether file whether zipfile was truncated when appending short… 
…er comment
  • Loading branch information
@mzr
mzr committed Sep 28, 2020
commit a93382e8d62e9b3ac1a17f2e3723762e42c5c7ab
10 changes: 4 additions & 6 deletions Lib/test/test_zipfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1853,17 +1853,15 @@ def test_comments(self):

# check that comments are correctly shortened in append mode
# and the file is indeed truncated
original_comment = b"original comment that's longer"
one_byte_shorter_comment = original_comment[:-1]
with zipfile.ZipFile(TESTFN,mode="w") as zipf:
zipf.comment = original_comment
zipf.comment = b"original comment that's longer"
zipf.writestr("foo.txt", "O, for a Muse of Fire!")
original_zip_size = os.path.getsize(TESTFN)
with zipfile.ZipFile(TESTFN,mode="a") as zipf:
zipf.comment = one_byte_shorter_comment
self.assertEqual(original_zip_size, os.path.getsize(TESTFN) + 1)
zipf.comment = b"shorter comment"
self.assertTrue(original_zip_size > os.path.getsize(TESTFN))
with zipfile.ZipFile(TESTFN,mode="r") as zipf:
self.assertEqual(zipf.comment, one_byte_shorter_comment)
self.assertEqual(zipf.comment, b"shorter comment")

def test_unicode_comment(self):
with zipfile.ZipFile(TESTFN, "w", zipfile.ZIP_STORED) as zipf:
Expand Down