Skip to content

bpo-40089: Add _at_fork_reinit() method to locks #19195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Apr 7, 2020
Merged

bpo-40089: Add _at_fork_reinit() method to locks #19195

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baadc73
bpo-40089: Add _at_fork_reinit() method to locks
vstinner Mar 27, 2020
b153154
Fix typos spotted by melanie witt
vstinner Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typos spotted by melanie witt
  • Loading branch information
@vstinner
vstinner committed Apr 3, 2020
commit b15315422c394d9d77d681bf5d3ff958e1450b15
4 changes: 2 additions & 2 deletions Python/thread_pthread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,11 +701,11 @@ _PyThread_at_fork_reinit(PyThread_type_lock *lock)
return -1;
}

/* bpo-6721, bpo-40089: The old lock can be in an inconistent state.
/* bpo-6721, bpo-40089: The old lock can be in an inconsistent state.
fork() can be called in the middle of an operation on the lock done by
another thread. So don't call PyThread_free_lock(*lock).

Leak memory on purpose. Don't release the memory neither since the
Leak memory on purpose. Don't release the memory either since the
address of a mutex is relevant. Putting two mutexes at the same address
can lead to problems. */

Expand Down