Skip to content

bpo-39812: Remove daemon threads in concurrent.futures #19149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 8 commits into from
Mar 27, 2020
Merged

bpo-39812: Remove daemon threads in concurrent.futures #19149

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3f03bd7
Remove daemon threads in concurrent.futures
aeros Mar 25, 2020
7686ba5
Fix whitespace
aeros Mar 25, 2020
21a12e9
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 25, 2020
b266ee5
Fix typo in threading._register_atexit() docstring
aeros Mar 25, 2020
320fc12
Immediately initialize _threading_atexits_
aeros Mar 25, 2020
e548615
Disallow new atexits after shutdown
aeros Mar 25, 2020
fdf66c3
Add unit tests for _register_atexit()
aeros Mar 25, 2020
4cf8c4e
Add whatsnew
aeros Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add whatsnew
  • Loading branch information
@aeros
aeros committed Mar 27, 2020
commit 4cf8c4eebfe85dc780179a822693882a733768ab
5 changes: 5 additions & 0 deletions Doc/whatsnew/3.9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,11 @@ which have not started running, instead of waiting for them to complete before
shutting down the executor.
(Contributed by Kyle Stanley in :issue:`39349`.)

Removed daemon threads from :class:`~concurrent.futures.ThreadPoolExecutor`
and :class:`~concurrent.futures.ProcessPoolExecutor`. This improves
Comment on lines +198 to +199

@aeros aeros Mar 27, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a tilde ~ shortens the Sphinx markup link to appear as just the last part, I.E. ThreadPoolExecutor and ProcessPoolExecutor. I typically use this when the classes are easily distinguishable based on their names alone, and the section already makes it clear what module it's in. This helps to make it a bit more succinct.

compatibility with subinterpreters and predictability in their shutdown
processes. (Contributed by Kyle Stanley in :issue:`39812`.)

curses
------

Expand Down