Skip to content

bpo-39868: Update Language Reference for PEP 572. #18793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 8 commits into from
Mar 6, 2020
Merged

bpo-39868: Update Language Reference for PEP 572. #18793

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ecddd10
Add PEP 572 grammar docs to the Language Reference.
brandtbucher Mar 6, 2020
c39c071
Update comment.
brandtbucher Mar 6, 2020
7377e52
NEWS.
brandtbucher Mar 6, 2020
04c9445
Update documented comprehension grammar.
brandtbucher Mar 6, 2020
6a0f640
Fix corner cases from PEP 572.
brandtbucher Mar 6, 2020
d5bb4a7
Remove stray line.
brandtbucher Mar 6, 2020
da3bc53
Fix bad copy-paste.
brandtbucher Mar 6, 2020
91d8f4d
Don't allow complex identifiers.
brandtbucher Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add PEP 572 grammar docs to the Language Reference.
  • Loading branch information
@brandtbucher
brandtbucher committed Mar 6, 2020
commit ecddd10a47b61fe1a5768638fea29e5eac6db5cb
6 changes: 3 additions & 3 deletions Doc/reference/compound_stmts.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ The :keyword:`!if` statement
The :keyword:`if` statement is used for conditional execution:

.. productionlist::
if_stmt: "if" `expression` ":" `suite`
: ("elif" `expression` ":" `suite`)*
if_stmt: "if" `assignment_expression` ":" `suite`
: ("elif" `assignment_expression` ":" `suite`)*
: ["else" ":" `suite`]

It selects exactly one of the suites by evaluating the expressions one by one

@gvanrossum gvanrossum Mar 6, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think "expression" here needs updating too? It becomes a bit ugly that way, and in context it doesn't seem ambiguous.

@gvanrossum gvanrossum Mar 6, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I thought more about it and I don't think it needs updating, so I'll land now.)

Expand All @@ -116,7 +116,7 @@ The :keyword:`while` statement is used for repeated execution as long as an
expression is true:

.. productionlist::
while_stmt: "while" `expression` ":" `suite`
while_stmt: "while" `assignment_expression` ":" `suite`
: ["else" ":" `suite`]

This repeatedly tests the expression and, if it is true, executes the first
Expand Down
11 changes: 11 additions & 0 deletions Doc/reference/expressions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1642,6 +1642,17 @@ returns a boolean value regardless of the type of its argument
(for example, ``not 'foo'`` produces ``False`` rather than ``''``.)


Assignment expressions
======================

.. productionlist::
assignment_expression: `conditional_expression` [":=" `conditional_expression`]

.. XXX TODO!

See :pep:`572` for more details about assignment expressions.


.. _if_expr:

Conditional expressions
Expand Down