Skip to content

bpo-39781: Do not jump when select in IDLE codecontext #18683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 6 commits into from
Feb 28, 2020
Merged

bpo-39781: Do not jump when select in IDLE codecontext #18683

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d20014e
Reformatting. Arrange BLOCKOPENTERS more logically
terryjreedy Feb 27, 2020
98bebd8
Don't jump if selection.
terryjreedy Feb 27, 2020
834c22c
tag_prevrange does not work on 'sel'; try index('sel.first')
terryjreedy Feb 28, 2020
cb7f71d
Test that selection stops jump.
terryjreedy Feb 28, 2020
4f8ecda
Exclude just-in-case TclError catching from coverage.
terryjreedy Feb 28, 2020
f44e1ab
News items.
terryjreedy Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test that selection stops jump.
  • Loading branch information
@terryjreedy
terryjreedy committed Feb 28, 2020
commit cb7f71d7822559b343c8d8f5034ac73d1d25d67d
8 changes: 8 additions & 0 deletions Lib/idlelib/idle_test/test_codecontext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,14 @@ def test_jumptoline(self):
jump()
eq(cc.topvisible, 8)

# Context selection stops jump.
cc.text.yview('5.0')
cc.update_code_context()
cc.context.tag_add('sel', '1.0', '2.0')
cc.context.mark_set('insert', '1.0')
jump() # Without selection, to line 2.
eq(cc.topvisible, 5)

@mock.patch.object(codecontext.CodeContext, 'update_code_context')
def test_timer_event(self, mock_update):
# Ensure code context is not active.
Expand Down