Skip to content

bpo-39488: skip bigfile test if not enough disk space #18261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 5 commits into from
Feb 5, 2020
Merged

bpo-39488: skip bigfile test if not enough disk space #18261

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79a8a97
skip if not enough disk space
giampaolo Jan 29, 2020
fbd5b3a
pass 'path' and 'required' args
giampaolo Jan 29, 2020
ffe8e35
pass file name
giampaolo Jan 30, 2020
182e4f1
add comment explaining required disk space
giampaolo Feb 3, 2020
4296e33
use size * 2.5
giampaolo Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Lib/test/test_largefile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,24 @@ def test_seekable(self):
self.assertTrue(f.seekable())


def skip_no_disk_space(path, required):
def decorator(fun):
def wrapper(*args, **kwargs):
if shutil.disk_usage(os.path.realpath(path)).free < required:
hsize = int(required / 1024 / 1024)
raise unittest.SkipTest(
f"required {hsize} MiB of free disk space")
return fun(*args, **kwargs)
return wrapper
return decorator


class TestCopyfile(LargeFileTest, unittest.TestCase):
open = staticmethod(io.open)

# Exact required disk space would be (size * 2), but let's give it a
# bit more tolerance.
@skip_no_disk_space(TESTFN, size * 2.5)
def test_it(self):
# Internally shutil.copyfile() can use "fast copy" methods like
# os.sendfile().
Expand Down Expand Up @@ -200,6 +215,9 @@ def run(sock):
self.thread.start()
event.set()

# Exact required disk space would be (size * 2), but let's give it a
# bit more tolerance.
@skip_no_disk_space(TESTFN, size * 2.5)
def test_it(self):
port = find_unused_port()
with socket.create_server(("", port)) as sock:
Expand Down