Skip to content

bpo-38599: Deprecate creation of asyncio object when the loop is not running #18195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eamanu wants to merge 14 commits into from
Closed

bpo-38599: Deprecate creation of asyncio object when the loop is not running #18195

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2941d1e
Deprecate creation of asyncio object when the loop is not running
eamanu Jan 26, 2020
7958de9
Add NEWS
eamanu Jan 26, 2020
976a808
Fix Deprecation Warning message.
eamanu Feb 5, 2020
44fa5f6
Remove change on BoundedSemaphore
eamanu Feb 10, 2020
e486fe4
add test
eamanu Feb 10, 2020
bae5755
Merge branch 'master' into fix-38599
eamanu Feb 11, 2020
18c4ddf
Fix tests
eamanu Feb 16, 2020
dc78f3a
Fix PR according to @aeros comments
eamanu Feb 26, 2020
1bb46a8
Fix according to review comments
eamanu Mar 13, 2020
0ca9f61
remove assertWarns on where is not applied
eamanu Mar 16, 2020
c4afc8f
Update Lib/asyncio/locks.py
eamanu Mar 16, 2020
ec3a6aa
fix grammar error
eamanu Mar 16, 2020
dd6dec3
Remove assertWarns not applied on queues test
eamanu Mar 16, 2020
c5d332a
Merge branch 'fix-38599' of github.com:eamanu/cpython into fix-38599
eamanu Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix according to review comments
  • Loading branch information
@eamanu
eamanu committed Mar 13, 2020
commit 1bb46a873b763901a9b8d76be9efc622d693e78b
60 changes: 24 additions & 36 deletions Lib/asyncio/locks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,14 @@ def __init__(self, *, loop=None):
self._waiters = None
self._locked = False
if loop is None:
self._loop = events.get_event_loop()
self._loop = events._get_running_loop()
if self._loop is None:
warnings.warn("The creation of asyncio objects outside a running "
Comment thread
eamanu marked this conversation as resolved.
Outdated
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)
self._loop = events.get_event_loop()
else:
self._loop = loop
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)
Comment on lines -84 to -86

@aeros aeros Mar 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be very confusing to users to add a deprecation warning in 3.8, and then remove the warning from certain asyncio objects entirely in 3.9. That doesn't make much sense to me.

(also applies to the other warning removals)


if not self._loop.is_running():
warnings.warn("The creation of asyncio objects without a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)

def __repr__(self):
res = super().__repr__()
Expand Down Expand Up @@ -179,17 +176,14 @@ def __init__(self, *, loop=None):
self._waiters = collections.deque()
self._value = False
if loop is None:
self._loop = events.get_event_loop()
self._loop = events._get_running_loop()
if self._loop is None:
warnings.warn("The creation of asyncio objects outside a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)
self._loop = events.get_event_loop()
else:
self._loop = loop
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)

if not self._loop.is_running():
warnings.warn("The creation of asyncio objects without a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)

def __repr__(self):
res = super().__repr__()
Expand Down Expand Up @@ -251,17 +245,14 @@ class Condition(_ContextManagerMixin):

def __init__(self, lock=None, *, loop=None):
if loop is None:
self._loop = events.get_event_loop()
self._loop = events._get_running_loop()
if self._loop is None:
warnings.warn("The creation of asyncio objects outside a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)
self._loop = events.get_event_loop()
else:
self._loop = loop
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)

if not self._loop.is_running():
warnings.warn("The creation of asyncio objects without a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)

if lock is None:
lock = Lock(loop=loop)
Expand Down Expand Up @@ -387,17 +378,14 @@ def __init__(self, value=1, *, loop=None):
self._value = value
self._waiters = collections.deque()
if loop is None:
self._loop = events.get_event_loop()
self._loop = events._get_running_loop()
if self._loop is None:
warnings.warn("The creation of asyncio objects outside a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)
self._loop = events.get_event_loop()
else:
self._loop = loop
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)

if not self._loop.is_running():
warnings.warn("The creation of asyncio objects without a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)

def __repr__(self):
res = super().__repr__()
Expand Down
16 changes: 7 additions & 9 deletions Lib/asyncio/queues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,16 @@ class Queue:

def __init__(self, maxsize=0, *, loop=None):
if loop is None:
self._loop = events.get_event_loop()
self._loop = events._get_running_loop()
if self._loop is None:
warnings.warn("The creation of asyncio objects outside a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)
self._loop = events.get_event_loop()
else:
self._loop = loop
warnings.warn("The loop argument is deprecated since Python 3.8, "
"and scheduled for removal in Python 3.10.",
DeprecationWarning, stacklevel=2)
self._maxsize = maxsize

if not self._loop.is_running():
warnings.warn("The creation of asyncio objects without a running "
"event loop is deprecated as of Python 3.9.",
DeprecationWarning, stacklevel=2)
self._maxsize = maxsize

# Futures.
self._getters = collections.deque()
Expand Down