Skip to content

bpo-38588: Optimize list comparison. #17766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 1 commit into from
Dec 31, 2019
Merged

bpo-38588: Optimize list comparison. #17766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-38588: Optimize list comparison. 
Mitigate performance regression of the list comparison caused by
2d5bf56.
  • Loading branch information
@methane
methane committed Dec 31, 2019
commit 84722afe798c099c1ab3ed4c8a69bf5aacdd1279
3 changes: 3 additions & 0 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2664,6 +2664,9 @@ list_richcompare(PyObject *v, PyObject *w, int op)
for (i = 0; i < Py_SIZE(vl) && i < Py_SIZE(wl); i++) {
PyObject *vitem = vl->ob_item[i];
PyObject *witem = wl->ob_item[i];
if (vitem == witem) {
continue;
}

Py_INCREF(vitem);
Py_INCREF(witem);
Expand Down