Skip to content

bpo-26730: Fix SpooledTemporaryFile data corruption #17400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 7 commits into from
Nov 27, 2019
Merged

bpo-26730: Fix SpooledTemporaryFile data corruption #17400

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
547b06f
bpo-26730: Fix SpooledTemporaryFile data corruption
methane Nov 27, 2019
ecb8858
update doc
methane Nov 27, 2019
30bb694
Add NEWS
methane Nov 27, 2019
adce72b
revert function -> class
methane Nov 27, 2019
70aeefa
Pass errors to TextIOWrapper
methane Nov 27, 2019
4b3d857
write_through is not required
methane Nov 27, 2019
c5fac2a
update test
methane Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update doc
  • Loading branch information
@methane
methane committed Nov 27, 2019
commit ecb8858eafec445371545485e4d9f8c02d1cc64f
6 changes: 3 additions & 3 deletions Doc/library/tempfile.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ The module defines the following user-callable items:
Added *errors* parameter.


.. function:: SpooledTemporaryFile(max_size=0, mode='w+b', buffering=None, encoding=None, newline=None, suffix=None, prefix=None, dir=None, *, errors=None)
.. class:: SpooledTemporaryFile(max_size=0, mode='w+b', buffering=None, encoding=None, newline=None, suffix=None, prefix=None, dir=None, *, errors=None)

This function operates exactly as :func:`TemporaryFile` does, except that
data is spooled in memory until the file size exceeds *max_size*, or
Expand All @@ -105,8 +105,8 @@ The module defines the following user-callable items:
causes the file to roll over to an on-disk file regardless of its size.

The returned object is a file-like object whose :attr:`_file` attribute
is either an :class:`io.BytesIO` or :class:`io.StringIO` object (depending on
whether binary or text *mode* was specified) or a true file
is either an :class:`io.BytesIO` or :class:`io.TextIOWrapper` object
(depending on whether binary or text *mode* was specified) or a true file
object, depending on whether :func:`rollover` has been called. This
file-like object can be used in a :keyword:`with` statement, just like
a normal file.
Expand Down