Skip to content

[3.8] bpo-38823: Fix refleak in _tracemalloc init error handling (GH-17235) #17282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Nov 20, 2019
Merged

[3.8] bpo-38823: Fix refleak in _tracemalloc init error handling (GH-17235) #17282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-38823: Fix refleak in _tracemalloc init error handling (GH-17235) 
(cherry picked from commit d51a363)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
  • Loading branch information
@brandtbucher @miss-islington
brandtbucher authored and miss-islington committed Nov 20, 2019
commit 27b96c617d7d8f5e07e10254fc0d1e11d95c8632
4 changes: 3 additions & 1 deletion Modules/_tracemalloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1637,8 +1637,10 @@ PyInit__tracemalloc(void)
if (m == NULL)
return NULL;

if (tracemalloc_init() < 0)
if (tracemalloc_init() < 0) {
Py_DECREF(m);
return NULL;
}

return m;
}
Expand Down