Skip to content

bpo-38328: Speed up the creation time of constant list and set literals. #17114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 12 commits into from
Nov 26, 2019
Merged

bpo-38328: Speed up the creation time of constant list and set literals. #17114

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f556e5e
Constify and unpack constant list and set literals.
brandtbucher Nov 12, 2019
f2f77fa
Regenerate importlib.
brandtbucher Nov 12, 2019
5006646
Resize overallocated list.
brandtbucher Nov 12, 2019
bebcf00
Branch on outer op, not single op.
brandtbucher Nov 12, 2019
2af72df
Handle PyFrozenSet_New failure.
brandtbucher Nov 12, 2019
58c96cf
Avoid name reuse.
brandtbucher Nov 12, 2019
6627e15
Add NEWS entry.
brandtbucher Nov 12, 2019
d61d204
Remove random cache file.
brandtbucher Nov 12, 2019
c140a12
Catch up with master.
brandtbucher Nov 25, 2019
f405957
Update 2019-11-11-23-44-15.bpo-38328.IFrrjq.rst
methane Nov 25, 2019
5285d67
Bump threshold to enable optimization.
brandtbucher Nov 25, 2019
3dfd17c
Regenerate importlib.
brandtbucher Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid name reuse.
  • Loading branch information
@brandtbucher
brandtbucher committed Nov 12, 2019
commit 58c96cfd13e0be55e9ae7f56fca3e9342200ebf9
8 changes: 4 additions & 4 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3659,11 +3659,11 @@ starunpack_helper(struct compiler *c, asdl_seq *elts,
if (folded == NULL) {
return 0;
}
PyObject *elt;
PyObject *val;
for (i = 0; i < n; i++) {
elt = ((expr_ty)asdl_seq_GET(elts, i))->v.Constant.value;
Py_INCREF(elt);
PyTuple_SET_ITEM(folded, i, elt);
val = ((expr_ty)asdl_seq_GET(elts, i))->v.Constant.value;
Py_INCREF(val);
PyTuple_SET_ITEM(folded, i, val);
}
if (outer_op == BUILD_SET_UNPACK) {
Py_SETREF(folded, PyFrozenSet_New(folded));
Expand Down