Skip to content

bpo-24658: Fix read/write on file with a size greater than 2GB on OSX #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 27 commits into from
Oct 17, 2018
Merged

bpo-24658: Fix read/write on file with a size greater than 2GB on OSX #1705

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f810129
bpo-24658: Fix read/write on file with a size greater than 2GB on OSX
matrixise May 21, 2017
1b7d412
bpo-24658: Clean the test file for test_large_reads_writes
matrixise May 22, 2017
3c447d8
bpo-24658: Improve the comment for the support of OSX for _PY_READ_MA…
matrixise May 22, 2017
b5b2754
bpo-24658: Improve the comment about macOS
matrixise May 22, 2017
1130c44
bpo-24658: Add the bigmemtest decorator for the test
matrixise May 22, 2017
207f00f
bpo-24658: just a test
matrixise May 22, 2017
7064bd5
bpo-24658: just a test
matrixise May 22, 2017
84b09f9
bpo-24658: just a test
matrixise May 22, 2017
a8c0aa1
bpo-24658: remove the requires and fix the comment
matrixise May 22, 2017
3d7fe38
bpo-24658: rename the test method
matrixise May 22, 2017
bb3e082
bpo-24658: remove unused imports
matrixise May 23, 2017
fc08e60
bpo-24658: check with bigmemtest
matrixise May 23, 2017
17d0d04
Add blurb entry
matrixise Oct 17, 2018
468dbbe
Add the missing symbols from test.support
matrixise Oct 17, 2018
4140591
Update with the review of Victor
matrixise Oct 17, 2018
86fa808
Update with the review of Victor
matrixise Oct 17, 2018
83dd759
Remove _2G, not used
matrixise Oct 17, 2018
15e176d
Update with the recommendations of Serhiy
matrixise Oct 17, 2018
d4ec7ec
fix test_large_read
matrixise Oct 17, 2018
a21bfcb
PEP 7 for the comments
matrixise Oct 17, 2018
4382256
Use memuse=2
matrixise Oct 17, 2018
a696899
Add comments
matrixise Oct 17, 2018
b8d1f24
Update the NEWS entry
matrixise Oct 17, 2018
3e887f5
Update the comments about the issues with read()/write() on macOS and…
matrixise Oct 17, 2018
530799a
Fix typo
matrixise Oct 17, 2018
4c9a61f
add comma
matrixise Oct 17, 2018
04ccd69
add space between 2 and GiB
matrixise Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add blurb entry
  • Loading branch information
@matrixise
matrixise committed Oct 17, 2018
commit 17d0d043fcd6d444fcac19e08276cdaeb68eb978
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/macOS/2018-10-17-14-36-08.bpo-24658.Naddgx.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix read/write on file with a size > 2GB on macOS

@vstinner vstinner Oct 17, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than ">", I would prefer to write:

On macOS, fix reading from and writing into a file with a size larger than 2 GiB.