Skip to content

[3.7] bpo-38275: Skip ssl tests for disabled versions (GH-16427) #16427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiran merged 2 commits into from
Sep 26, 2019
Merged

[3.7] bpo-38275: Skip ssl tests for disabled versions (GH-16427) #16427

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0754be5
[3.7] bpo-38275: Skip ssl tests for disabled versions (GH-16386)
tiran Sep 26, 2019
83f7f7b
bpo-38275: Fix for GH-16386
tiran Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bpo-38275: Fix for GH-16386 
Check presence of SSLContext.minimum_version to make tests pass with
old versions of OpenSSL.

Signed-off-by: Christian Heimes <christian@python.org>
  • Loading branch information
@tiran
tiran committed Sep 26, 2019
commit 83f7f7be0930ca2f153cc64a0b3297f451d458c8
2 changes: 2 additions & 0 deletions Lib/test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,11 +186,13 @@ def has_tls_version(version):
# be compiled in but disabled by a policy or config option.
ctx = ssl.SSLContext()
if (
hasattr(ctx, 'minimum_version') and
ctx.minimum_version != ssl.TLSVersion.MINIMUM_SUPPORTED and
version < ctx.minimum_version
):
return False
if (
hasattr(ctx, 'maximum_version') and
ctx.maximum_version != ssl.TLSVersion.MAXIMUM_SUPPORTED and
version > ctx.maximum_version
):
Expand Down