Skip to content

bpo-37224: Fix test__xxsubinterpreters failure and GIL handling in interp_destroy() #16293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aeros wants to merge 4 commits into from
Closed

bpo-37224: Fix test__xxsubinterpreters failure and GIL handling in interp_destroy() #16293

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
136d307
Fix destroy_interp() GIL handling
aeros Sep 20, 2019
cfbcddf
Adjust interp_destroy() comment
aeros Sep 20, 2019
4a28d9a
Fix whitespace in interp_destroy()
aeros Sep 20, 2019
4e7fd63
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust interp_destroy() comment
  • Loading branch information
@aeros
aeros committed Sep 20, 2019
commit cfbcddf747ee4b708d23a812a6364b68da747c81
2 changes: 1 addition & 1 deletion Modules/_xxsubinterpretersmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2054,7 +2054,7 @@ interp_destroy(PyObject *self, PyObject *args, PyObject *kwds)
if (_ensure_not_running(interp) < 0) {
return NULL;
}
// Ensure current thread has the GIL (bpo-38154)
// Safely ensure current thread has the GIL (bpo-38154)
PyThreadState *current_tstate = PyGILState_GetThisThreadState();
if (!_Py_IsFinalizing() && !PyGILState_Check()){
PyEval_RestoreThread(current_tstate);
Expand Down