Skip to content

bpo-38112: Compileall improvements #16012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 13 commits into from
Sep 26, 2019
Merged

bpo-38112: Compileall improvements #16012

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dec5871
Raise the limit of maximum path depth to actual recursion limit
frenzymadness Sep 6, 2019
268acef
[refactoring] ddir arg is useless in _walk_dir function
frenzymadness Sep 6, 2019
dae2c6a
Add posibilities to adjust a path compiled in .pyc file.
frenzymadness Sep 6, 2019
3ce38d7
Add a possibility to specify multiple optimization levels
frenzymadness Sep 6, 2019
23ef6f9
Add a symlinks limitation feature
frenzymadness Sep 7, 2019
ba1a47c
Add test of maxlevels attribute of compile_dir function
frenzymadness Sep 7, 2019
a5118d2
Add tests for new features strip/prepend
frenzymadness Sep 7, 2019
21acf0d
Add tests for multiple optimization levels
frenzymadness Sep 7, 2019
6ecce95
Add tests for symlinks limit feature
frenzymadness Sep 7, 2019
1009e79
Test behavior of compileall with a symlink loop
encukou Sep 12, 2019
6c24694
Adjust documentation
encukou Sep 12, 2019
0783a29
Add NEWS entry for compileall module changes
frenzymadness Sep 24, 2019
7e1ed0f
Raise an agrparse error for bad arguments; update documentation
encukou Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for symlinks limit feature
  • Loading branch information
@frenzymadness
frenzymadness committed Sep 24, 2019
commit 6ecce95aa2c00a3603e80953f67986fd92c26949
50 changes: 50 additions & 0 deletions Lib/test/test_compileall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,31 @@ def test_multiple_optimization_levels(self):
except Exception:
pass

@support.skip_unless_symlink
def test_ignore_symlink_destination(self):
# Create folders for allowed files, symlinks and prohibited area
allowed_path = os.path.join(self.directory, "test", "dir", "allowed")
symlinks_path = os.path.join(self.directory, "test", "dir", "symlinks")
prohibited_path = os.path.join(self.directory, "test", "dir", "prohibited")
os.makedirs(allowed_path)
os.makedirs(symlinks_path)
os.makedirs(prohibited_path)

# Create scripts and symlinks and remember their byte-compiled versions
allowed_script = script_helper.make_script(allowed_path, "test_allowed", "a = 0")
prohibited_script = script_helper.make_script(prohibited_path, "test_prohibited", "a = 0")
allowed_symlink = os.path.join(symlinks_path, "test_allowed.py")
prohibited_symlink = os.path.join(symlinks_path, "test_prohibited.py")
os.symlink(allowed_script, allowed_symlink)
os.symlink(prohibited_script, prohibited_symlink)
allowed_bc = importlib.util.cache_from_source(allowed_symlink)
prohibited_bc = importlib.util.cache_from_source(prohibited_symlink)

compileall.compile_dir(symlinks_path, quiet=True, limit_sl_dest=allowed_path)

self.assertTrue(os.path.isfile(allowed_bc))
self.assertFalse(os.path.isfile(prohibited_bc))


class CompileallTestsWithSourceEpoch(CompileallTestsBase,
unittest.TestCase,
Expand Down Expand Up @@ -722,6 +747,31 @@ def test_multiple_optimization_levels(self):
except Exception:
pass

@support.skip_unless_symlink
def test_ignore_symlink_destination(self):
# Create folders for allowed files, symlinks and prohibited area
allowed_path = os.path.join(self.directory, "test", "dir", "allowed")
symlinks_path = os.path.join(self.directory, "test", "dir", "symlinks")
prohibited_path = os.path.join(self.directory, "test", "dir", "prohibited")
os.makedirs(allowed_path)
os.makedirs(symlinks_path)
os.makedirs(prohibited_path)

# Create scripts and symlinks and remember their byte-compiled versions
allowed_script = script_helper.make_script(allowed_path, "test_allowed", "a = 0")
prohibited_script = script_helper.make_script(prohibited_path, "test_prohibited", "a = 0")
allowed_symlink = os.path.join(symlinks_path, "test_allowed.py")
prohibited_symlink = os.path.join(symlinks_path, "test_prohibited.py")
os.symlink(allowed_script, allowed_symlink)
os.symlink(prohibited_script, prohibited_symlink)
allowed_bc = importlib.util.cache_from_source(allowed_symlink)
prohibited_bc = importlib.util.cache_from_source(prohibited_symlink)

self.assertRunOK(symlinks_path, "-e", allowed_path)

self.assertTrue(os.path.isfile(allowed_bc))
self.assertFalse(os.path.isfile(prohibited_bc))


class CommandLineTestsWithSourceEpoch(CommandLineTestsBase,
unittest.TestCase,
Expand Down