Skip to content

gh-159398: Validate strings read from remote process in _remote_debugging #159402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StanFromIreland wants to merge 5 commits into
base: main
Choose a base branch
from
+99 −26
Open

gh-159398: Validate strings read from remote process in _remote_debugging #159402

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0517659
Validate strings read from remote process in `_remote_debugging`
StanFromIreland Oct 14, 2026
c9cd047
Apply Victor's suggestions, and actually fix the bug
StanFromIreland Oct 14, 2026
5006065
Apply batched suggestions from code review
StanFromIreland Oct 16, 2026
175c0bd
Switch errors
StanFromIreland Oct 16, 2026
661bebf
Add `test_long_qualname_truncated_to_narrower_kind`
StanFromIreland Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test_long_qualname_truncated_to_narrower_kind
  • Loading branch information
@StanFromIreland
StanFromIreland committed Oct 16, 2026
commit 661bebf654970dbc4dbf7295212e522e3a824e1a
13 changes: 13 additions & 0 deletions Lib/test/test_external_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4449,6 +4449,19 @@ def test_long_qualname_truncated_not_dropped(self):
self.assertIsNotNone(frame)
self.assertEqual(frame.funcname, "f" * 1024)

def test_long_qualname_truncated_to_narrower_kind(self):
name = "a" * 1024 + "\U00010300"
src = f"def {name}(sample):\n return sample()\n"
ns = {}
exec(src, ns)

trace = ns[name](RemoteUnwinder(os.getpid()).get_stack_trace)
frame = self._find_frame_in_trace(
trace, lambda f: f.funcname.startswith("aaa")
)
self.assertIsNotNone(frame)
self.assertEqual(frame.funcname, "a" * 1024)

def test_long_filename_truncated(self):
"""A filename longer than 1024 chars is truncated instead of
failing the whole sample."""
Expand Down
Loading