Skip to content

gh-159320: use pthread_getattr_np for stack limit checks even on musl #159376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yhg1s wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-159320: use pthread_getattr_np for stack limit checks even on musl #159376

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
723c722
Rewrite the pthread_getattr_np usage to avoid the problem on musl of it
Yhg1s Oct 13, 2026
9569c07
Add HAVE_UNRELIABLE_PTHREAD_GETATTR_NP to the long, long list of ignored
Yhg1s Oct 13, 2026
8793527
Merge branch 'main' into musl-stack-check
Yhg1s Oct 14, 2026
79f0f93
Merge branch 'main' into musl-stack-check
Yhg1s Oct 14, 2026
036f753
Fix punctuation/formatting.
Yhg1s Oct 14, 2026
e78cfd2
Fix a comment to make it clear the correctness of pthread_getattr_np …
Yhg1s Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix a comment to make it clear the correctness of pthread_getattr_np … 
…doesn't

depend on explicitly setting the stack size. It's correct for new threads
regardless of that call.
  • Loading branch information
@Yhg1s
Yhg1s committed Oct 16, 2026
commit e78cfd2c627eca892e21102176cb57b0a86f14bb
5 changes: 2 additions & 3 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,8 @@ hardware_stack_limits(uintptr_t *base, uintptr_t *top, uintptr_t sp)
# ifdef HAVE_UNRELIABLE_PTHREAD_GETATTR_NP
/* pthread_getattr_np on the main thread of a musl process reports a
* stack size based on the current stack rather than RLIMIT_STACK.
* New threads pass their size to pthread_attr_setstacksize and are
* reported correctly even on musl, so this fallback only applies to
* the main thread. */
* New threads are reported correctly even on musl, so this fallback
* only applies to the main thread. */
if ((pid_t)syscall(SYS_gettid) == getpid()) {
struct rlimit rl;
if (getrlimit(RLIMIT_STACK, &rl) == 0 &&
Expand Down
Loading