Repository navigation
[3.15] gh-159185: Fix marshalling of a set modified while its elements are marshalled (GH-159195) - #159199
Merged
Conversation
…lements are marshalled (pythonGH-159195) Marshalling a set element can run Python code (__buffer__, an audit hook) which changes the set. The number of elements was read before the loop, so a set which grew was written past the end of the list and one which shrank left NULL items in the list which was then sorted. Raise RuntimeError("set changed size during iteration") instead. (cherry picked from commit cd71799)
This was referenced Oct 11, 2026
bedevere-app
Bot
added
the
type-crash
gpshead
marked this pull request as ready for review
October 11, 2026 21:51
gpshead
enabled auto-merge (squash)
October 11, 2026 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marshalling a set element can run Python code (
__buffer__, an audit hook) which changes the set. The number of elements was read before the loop, so a set which grew was written past the end of the list and one which shrank left NULL items in the list which was then sorted. Raise RuntimeError("set changed size during iteration") instead.(cherry picked from commit cd71799)
[draft while determining if other backports should land first that would've let this be an automated backport]
marshal.dumps()crashes when a set is modified while it is being marshalled #159185