Skip to content

gh-130698: Convert sys.ps1 and sys.ps2 to strings before PyREPL use #158828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StanFromIreland merged 7 commits into from
Oct 23, 2026
+54 −5
Merged

gh-130698: Convert sys.ps1 and sys.ps2 to strings before PyREPL use #158828

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d20d6df
gh-158827: Convert `sys.ps1` and `sys.ps2` to strings before PyREPL use
edvilme Oct 5, 2026
9d68e4d
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 5, 2026
392d59b
Update Misc/NEWS.d/next/Library/2026-10-05-08-35-10.gh-issue-130698.i…
edvilme Oct 5, 2026
82fd0c0
Merge branch 'main' into pyrepl-str
edvilme Oct 5, 2026
492e961
Prompt fallback when __str__ raises
edvilme Oct 20, 2026
eeb7d86
Tweak blurb
StanFromIreland Oct 23, 2026
52702a2
Merge branch 'main' into pyrepl-str
StanFromIreland Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/_pyrepl/simple_interact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ def maybe_run_command(statement: str) -> bool:
except Exception:
pass

ps1 = getattr(sys, "ps1", ">>> ")
ps2 = getattr(sys, "ps2", "... ")
ps1 = str(getattr(sys, "ps1", ">>> "))
ps2 = str(getattr(sys, "ps2", "... "))
try:
statement = multiline_input(more_lines, ps1, ps2)
except EOFError:
Expand Down
30 changes: 28 additions & 2 deletions Lib/test/test_pyrepl/test_interact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,42 @@
import contextlib
import io
import sys
import warnings
import unittest
from unittest.mock import patch
from unittest.mock import ANY, patch
from textwrap import dedent

from test.support import force_not_colorized

from _pyrepl.console import InteractiveColoredConsole
from _pyrepl.simple_interact import _more_lines
from _pyrepl.simple_interact import (
_more_lines,
run_multiline_interactive_console,
)

class TestSimpleInteract(unittest.TestCase):
def test_prompts_are_converted_to_strings(self):
console = InteractiveColoredConsole()

class Prompt:
def __init__(self, value):
self.value = value

def __str__(self):
return self.value

with (
patch.object(sys, "ps1", Prompt("primary"), create=True),
patch.object(sys, "ps2", Prompt("secondary"), create=True),
patch("_pyrepl.readline._setup"),
patch(
"_pyrepl.simple_interact.multiline_input", side_effect=EOFError
) as multiline_input,
):
run_multiline_interactive_console(console)

multiline_input.assert_called_once_with(ANY, "primary", "secondary")

def test_multiple_statements(self):
namespace = {}
code = dedent("""\
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-10-05-08-35-10.gh-issue-130698.iibO9V.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix issue where PyREPL would overflow with errors when assigning a string-representable object to ``sys.ps1``
Comment thread
edvilme marked this conversation as resolved.
Outdated
Loading