Skip to content

gh-158795: Fix unused tracing table warning with --with-tail-call-interp #158796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-158795: Fix unused tracing table warning with --with-tail-call-interp #158796

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aecc3c4
gh-158795: Fix unused tracing table warning with --with-tail-call-interp
lazerg Oct 4, 2026
856d163
Remove NEWS entry
lazerg Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2026-10-04-13-00-14.gh-issue-158795.zYlNgM.rst
View file
Open in desktop

@StanFromIreland StanFromIreland Oct 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a warning, we don't need a blurb.

@lazerg lazerg Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 856d163.

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix an unused variable compiler warning for the tracing dispatch table when
building with :option:`--with-tail-call-interp` without the JIT.
4 changes: 4 additions & 0 deletions Modules/_testinternalcapi/test_targets.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions Python/opcode_targets.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions Tools/cases_generator/target_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ def function_proto(name: str) -> str:
def write_tailcall_dispatch_table(analysis: Analysis, out: CWriter) -> None:
out.emit("static py_tail_call_funcptr instruction_funcptr_handler_table[256];\n")
out.emit("\n")
out.emit("#if _Py_TIER2\n")
out.emit("static py_tail_call_funcptr instruction_funcptr_tracing_table[256];\n")
out.emit("#endif\n")
out.emit("\n")

# Emit function prototypes for labels.
Expand Down Expand Up @@ -82,6 +84,7 @@ def write_tailcall_dispatch_table(analysis: Analysis, out: CWriter) -> None:
out.emit("};\n")

# Emit the tracing dispatch table.
out.emit("#if _Py_TIER2\n")
out.emit("static py_tail_call_funcptr instruction_funcptr_tracing_table[256] = {\n")
for name in sorted(analysis.instructions.keys()):
out.emit(f"[{name}] = _TAIL_CALL_TRACE_RECORD,\n")
Expand All @@ -90,6 +93,7 @@ def write_tailcall_dispatch_table(analysis: Analysis, out: CWriter) -> None:
if rest not in named_values:
out.emit(f"[{rest}] = _TAIL_CALL_UNKNOWN_OPCODE,\n")
out.emit("};\n")
out.emit("#endif\n")
outfile.write("#endif /* _Py_TAIL_CALL_INTERP */\n")

arg_parser = argparse.ArgumentParser(
Expand Down
Loading