Conversation
Split the attribute lists so the 'supports_*' names don't need to be repeated twice. Add 'supports_dir_fd'.
encukou
added
type-feature
vstinner
approved these changes
Oct 2, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
The variables are formatted/logged properly:
$ ./python -m test.pythoninfo|grep -E '^os\.(supports|name|supports_bytes_environ)'
os.name: posix
os.supports_bytes_environ: True
os.supports_dir_fd: ['access', 'chmod', 'chown', 'link', 'lstat', 'mkdir', 'mkfifo', 'mknod', 'open', 'readlink', 'rename', 'rmdir', 'stat', 'statx', 'symlink', 'unlink', 'utime']
os.supports_effective_ids: ['access']
os.supports_fd: ['chdir', 'chmod', 'chown', 'execve', 'listdir', 'pathconf', 'scandir', 'stat', 'statvfs', 'statx', 'truncate', 'utime']
os.supports_follow_symlinks: ['access', 'chown', 'link', 'stat', 'statx', 'utime']
StanFromIreland
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked for
os.supports_dir_fdthis when investigating the 3.13 Android failure on GH-158429, and realized we don't show it yet.(So I need this and #146410 backported to 3.13, but, this PR should be useful even if that doesn't happen.)
Split the attribute lists so the 'supports_*' names don't need to be repeated twice.
Add 'supports_dir_fd'.