Repository navigation
gh-157875: Fix reference leak when a JIT trace is rewound - #157889
Closed
tonyyuyiding wants to merge 2 commits into
Closed
tonyyuyiding wants to merge 2 commits into
tonyyuyiding wants to merge 2 commits into
Conversation
tonyyuyiding
marked this pull request as ready for review
September 21, 2026 07:45
tonyyuyiding
requested review from
Fidget-Spinner and
markshannon
as code owners
September 21, 2026 07:45
Member
|
Thanks, but this appears to be a duplicate of #157888. |
OOTS
added a commit
to OOTS/cpython
that referenced
this pull request
Sep 27, 2026
…ddress feedback from MR. * os.readlink() now returns a `str` (rather than `bytes`) when called with a file descriptor. * os.readlink now added to `os.supports_fd` on the platforms where this feature is supported. * Small refactor inside `os.readlink`: drop *_unavailable variables, generate error messages inline. Py_BEGIN_ALLOW_THREADS/Py_END_ALLOW_THREADS around each syscall site. * Docs: Android is now mentioned as supported platform for this feature in all relevant places.
OOTS
added a commit
to OOTS/cpython
that referenced
this pull request
Sep 27, 2026
Emscripten apparrently defines O_PATH and readlinkat - even though it doesn't actually support them. This broke auto-detection of whether os.readlink supports FDs - which broke the tests.
OOTS
added a commit
to OOTS/cpython
that referenced
this pull request
Sep 29, 2026
* Simplified/unified error handling in case reading fds referring to symlinks is not supported. * Docs: centralized the information on the return type of os.readlink in a single paragraph. * Docs/comments: rewrite from "MacOS" to "macOS" (lower-case).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.