Skip to content

gh-157875: Fix reference leak when a JIT trace is rewound - #157889

Closed
tonyyuyiding wants to merge 2 commits into
python:mainfrom
tonyyuyiding:fix-gh-157875
Closed

tonyyuyiding wants to merge 2 commits into
python:mainfrom
tonyyuyiding:fix-gh-157875

Conversation

@tonyyuyiding

@tonyyuyiding tonyyuyiding commented Sep 21, 2026 •

Copy link
Copy Markdown

@tonyyuyiding
tonyyuyiding marked this pull request as ready for review September 21, 2026 07:45
@cocolato

Copy link
Copy Markdown
Member

Thanks, but this appears to be a duplicate of #157888.

OOTS added a commit to OOTS/cpython that referenced this pull request Sep 27, 2026
…ddress feedback from MR.

* os.readlink() now returns a `str` (rather than `bytes`) when called with a file descriptor.
* os.readlink now added to `os.supports_fd` on the platforms where this feature is supported.
* Small refactor inside `os.readlink`: drop *_unavailable variables, generate error messages inline.
  Py_BEGIN_ALLOW_THREADS/Py_END_ALLOW_THREADS around each syscall site.
* Docs: Android is now mentioned as supported platform for this feature in all relevant places.
OOTS added a commit to OOTS/cpython that referenced this pull request Sep 27, 2026
Emscripten apparrently defines O_PATH and readlinkat - even though it doesn't actually support them.
This broke auto-detection of whether os.readlink supports FDs - which broke the tests.
OOTS added a commit to OOTS/cpython that referenced this pull request Sep 29, 2026
* Simplified/unified error handling in case reading fds referring to symlinks is not supported.
* Docs: centralized the information on the return type of os.readlink in a single paragraph.
* Docs/comments: rewrite from "MacOS" to "macOS" (lower-case).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants