Skip to content

gh-157788: Fix python -m asyncio ps failing on long task names #157790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 2 commits into from
Sep 19, 2026
Merged

gh-157788: Fix python -m asyncio ps failing on long task names #157790

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a39f9a
gh-157788: Fix python -m asyncio ps failing on long task names
deadlovelll Sep 19, 2026
4ecf22d
remove test
deadlovelll Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions Lib/test/test_external_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import asyncio
import unittest
import os
import textwrap
Expand Down Expand Up @@ -440,6 +441,45 @@ def _extract_coroutine_stacks_lineno_only(self, stack_trace):

@requires_remote_subprocess_debugging()
class TestSelfStackTrace(RemoteInspectionTestBase):
@skip_if_not_supported
def test_long_task_name_is_truncated(self):
# gh-157788
async def main():
asyncio.create_task(asyncio.sleep(10_000), name="x" * 300)
await asyncio.sleep(0)
return [
task.task_name
for info in RemoteUnwinder(os.getpid()).get_all_awaited_by()
for task in info.awaited_by
]

names = asyncio.run(main())
self.assertIn("Task-1", names)
self.assertEqual([len(n) for n in names if n.startswith("x")], [255])

@skip_if_not_supported
def test_negative_string_length_is_rejected(self):
# gh-157788
import ctypes

async def main():
name = "corrupted" + "x" * 20
asyncio.create_task(asyncio.sleep(10_000), name=name)
await asyncio.sleep(0)

length = ctypes.c_ssize_t.from_address(
Comment thread
pablogsal marked this conversation as resolved.
Outdated
id(name) + object().__sizeof__())
real_length = length.value
length.value = -1
try:
with self.assertRaisesRegex(RuntimeError,
"Invalid string length"):
RemoteUnwinder(os.getpid()).get_all_awaited_by()
finally:
length.value = real_length

asyncio.run(main())

@skip_if_not_supported
@unittest.skipIf(
sys.platform == "linux" and not PROCESS_VM_READV_SUPPORTED,
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-09-19-14-10-18.gh-issue-157788.v70Lxd.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix ``python -m asyncio ps`` failing on a process that has a task with a
name longer than 255 characters.
6 changes: 5 additions & 1 deletion Modules/_remote_debugging/object_reading.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,16 @@ read_py_str(
}

Py_ssize_t len = GET_MEMBER(Py_ssize_t, unicode_obj, unwinder->debug_offsets.unicode_object.length);
if (len < 0 || len > max_len) {
if (len < 0) {
PyErr_Format(PyExc_RuntimeError,
"Invalid string length (%zd) at 0x%lx", len, address);
set_exception_cause(unwinder, PyExc_RuntimeError, "Invalid string length in remote Unicode object");
return NULL;
}
if (len > max_len) {
// gh-157788: a long name must not fail the whole read
len = max_len;
}

// Inspect state to pick the right data offset and character width.
// We rely on the remote process sharing this Python version's
Expand Down
Loading