Skip to content

gh-141044: Fix ASan leak with small threading.stack_size() #157691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KingLizard1020 wants to merge 25 commits into
base: main
Choose a base branch
from
Open

gh-141044: Fix ASan leak with small threading.stack_size() #157691

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
00fe666
gh-141044: Fix ASan leak with small threading.stack_size()
KingLizard1020 Sep 17, 2026
3aef310
gh-141044: Require 6 stack margins on debug builds too
KingLizard1020 Sep 21, 2026
09dc0cb
gh-141044: Update NEWS for debug/sanitizer 6-margin floor
KingLizard1020 Sep 21, 2026
04ebedb
gh-141044: Portable 127 KiB stack_size rejection check
KingLizard1020 Sep 21, 2026
bfbf64c
gh-141044: Restore test_thread.py (undo accidental PLACEHOLDER)
KingLizard1020 Sep 21, 2026
7f942ca
gh-141044: Silence NEWS Sphinx nit for _thread.stack_size
KingLizard1020 Sep 21, 2026
1fac29a
gh-141044: Raise TSan stack_size floor to 12 margins
KingLizard1020 Sep 21, 2026
0f0971d
gh-141044: Update NEWS for TSan 12-margin stack_size floor
KingLizard1020 Sep 21, 2026
f2242a1
gh-141044: Allow stack_size tests to skip 256 KiB under TSan
KingLizard1020 Sep 21, 2026
4d72b7e
gh-141044: Skip 256 KiB stack tests when below TSan floor
KingLizard1020 Sep 21, 2026
c15bbbd
temp: canary for restore path (will remove)
KingLizard1020 Sep 21, 2026
ab3acf1
temp: escape-test canary (will remove)
KingLizard1020 Sep 21, 2026
c43e6b8
wip: restore test_threading.py (5KB partial)
KingLizard1020 Sep 21, 2026
d012c29
temp: remove restore canary
KingLizard1020 Sep 21, 2026
12213d2
test @file
KingLizard1020 Sep 21, 2026
bb6fe83
wip: restore test_threading.py (5KB partial, undo @path probe)
KingLizard1020 Sep 21, 2026
124b140
gh-141044: Fix Docs soft-deprecated KeyError in changes builder
KingLizard1020 Sep 21, 2026
f609ce4
Add cpy test_threading restore part _cpy_tt_part_0.b64 (no trigger)
KingLizard1020 Sep 21, 2026
fe78d4b
Add cpy test_threading restore part _cpy_tt_part_1.b64 (no trigger)
KingLizard1020 Sep 21, 2026
4eb90e5
Fix part1 chunk0 of cpy test_threading restore
KingLizard1020 Sep 21, 2026
6222f46
Restore threading regression tests and update from main
KingLizard1020 Sep 22, 2026
de3886e
Fix threading tests for sanitizer stack minimum
KingLizard1020 Sep 22, 2026
be750c5
Merge upstream main into PR #157691
KingLizard1020 Sep 23, 2026
af31989
Merge branch 'main' into cursor/fix-threading-stack-size-leak-a999
KingLizard1020 Sep 24, 2026
db9370d
Merge remote-tracking branch 'upstream/main' into cursor/fix-threadin…
KingLizard1020 Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-141044: Update NEWS for debug/sanitizer 6-margin floor
  • Loading branch information
@KingLizard1020
KingLizard1020 committed Sep 21, 2026
commit 09dc0cb75c6553bf6c3cca6b4a81be733116839e
10 changes: 5 additions & 5 deletions Misc/NEWS.d/next/Library/2026-09-14-20-45-00.gh-issue-141044.Ks8nQm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Fix a reference leak when creating a :class:`threading.Thread` after
setting a small custom stack size with :func:`threading.stack_size` in
AddressSanitizer builds. ASan instrumentation needs extra C stack, so
:func:`_thread.stack_size` now requires the same 6 stack margins used
with ThreadSanitizer. Sizes that previously appeared to work under ASan
(for example 127 KiB) now raise :exc:`ValueError`. Non-ASan builds are
unchanged. Patch by Kailash Nelson.
debug and sanitizer builds. Those builds need extra C stack, so
:func:`_thread.stack_size` now requires 6 stack margins (as ThreadSanitizer
already did). Sizes that previously appeared to work (for example 127 KiB
on 64-bit debug/ASan builds) now raise :exc:`ValueError`. Release builds
are unchanged. Patch by Kailash Nelson.
Loading