Skip to content

gh-157676: Fix KeyError in tkinter.simpledialog when a foreign window holds the grab #157677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 4 commits into from
Sep 29, 2026
Merged

gh-157676: Fix KeyError in tkinter.simpledialog when a foreign window holds the grab #157677

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7560111
gh-157676: Fix KeyError in tkinter.simpledialog when a foreign window…
serhiy-storchaka Sep 17, 2026
a89df13
Catch errors when restoring the focus and the grab
serhiy-storchaka Sep 21, 2026
8ba6469
Do not check the focus on Windows if the application did not get it
serhiy-storchaka Sep 21, 2026
c0a3971
Do not check the focus on Windows
serhiy-storchaka Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Catch errors when restoring the focus and the grab 
The dialog can destroy a temporary default root, and then even "winfo"
fails with "application has been destroyed".
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Sep 21, 2026
commit a89df13e667db3de553f2a0f0fb0ea216d4e02ee
22 changes: 13 additions & 9 deletions Lib/tkinter/simpledialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,9 @@ def _temp_grab_focus(grab, focus=None, destroy=True):
yield

finally:
if old_focus and grab.getboolean(tk.call('winfo', 'exists', old_focus)):
# The old windows and even the whole application can be destroyed
# by now, so catch errors.
if old_focus:
try:
tk.call('focus', old_focus)
except TclError:
Expand All @@ -756,15 +758,17 @@ def _temp_grab_focus(grab, focus=None, destroy=True):
grab.destroy()
except TclError:
pass
if (old_grab and grab.getboolean(tk.call('winfo', 'exists', old_grab))
and grab.getboolean(tk.call('winfo', 'ismapped', old_grab))):
# The "grab" command will fail if another application
# already holds the grab. So catch it.
if old_grab:
# Do not restore the grab if the window is no longer mapped:
# a local grab on an unmapped window would block the application.
# The "grab" command will fail if another application already
# holds the grab on a window with the same name. So catch it.
try:
if old_status == 'global':
tk.call('grab', 'set', '-global', old_grab)
else:
tk.call('grab', 'set', old_grab)
if grab.getboolean(tk.call('winfo', 'ismapped', old_grab)):
if old_status == 'global':
tk.call('grab', 'set', '-global', old_grab)
else:
tk.call('grab', 'set', old_grab)
except TclError:
pass

Expand Down
Loading