Skip to content

gh-122622: Add PyREPL simple_interact.statement_submitted_hook #157241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edvilme wants to merge 12 commits into
base: main
Choose a base branch
from
+105 −1
Open

gh-122622: Add PyREPL simple_interact.statement_submitted_hook #157241

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4c18d3b
gh-122622: Add PyREPL pre-execution hook
edvilme Sep 9, 2026
b988e6f
Add empty pre_execution_hook for feature detection
edvilme Sep 9, 2026
7d9ddbf
Update tests to verify no interference
edvilme Sep 9, 2026
ad17396
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 9, 2026
0ef602c
Update NEWS
edvilme Sep 9, 2026
8ede9b2
Address feedback
edvilme Sep 18, 2026
6d7dfe0
Address feedback
edvilme Sep 19, 2026
d45c1d3
Merge branch 'main' into pyrepl-hook
edvilme Sep 19, 2026
e1186d5
Show tracebakcs
edvilme Sep 21, 2026
f615af2
Add tests to make sure hook runs before exception
edvilme Sep 23, 2026
f766b48
Update comment
edvilme Oct 13, 2026
a81c71a
Fix incorrect comment
edvilme Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests to make sure hook runs before exception
  • Loading branch information
@edvilme
edvilme committed Sep 23, 2026
commit f615af20aaf30907002b962ec1591b1ba0b993e9
20 changes: 19 additions & 1 deletion Lib/test/test_pyrepl/test_interact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,6 @@ def f():


class TestStatementSubmittedHook(unittest.TestCase):

def _run_interactive(self, statements, hook):
console = InteractiveColoredConsole()
statement_iter = iter(statements)
Expand Down Expand Up @@ -352,8 +351,27 @@ def test_hook_exception_is_displayed(self):
self.assertIn("RuntimeError: hook error", output)
self.assertEqual(namespace["x"], 1)

def test_hook_return_value_is_ignored(self):
hook = MagicMock(return_value=True)

_, namespace = self._run_interactive(["x = 1"], hook)

self.assertEqual(namespace["x"], 1)

def test_hook_not_called_for_repl_commands(self):
hook = MagicMock()
self._run_interactive(["clear"], hook)

hook.assert_not_called()

@force_not_colorized
def test_hook_called_before_execution_exception(self):
statement = "1 / 0"
marker = "hook ran first"
hook = MagicMock(side_effect=lambda statement: print(marker))
output, _ = self._run_interactive([statement], hook)

hook.assert_called_once_with(statement)
marker_index = output.index(marker)
traceback_index = output.index("ZeroDivisionError")
self.assertLess(marker_index, traceback_index)
Loading