Skip to content

gh-153740: refine test for _Float16 (check support from libm) #156815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Sep 2, 2026
Merged

gh-153740: refine test for _Float16 (check support from libm) #156815

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0567678
gh-153740: refine test for _Float16 (check support from libm)
skirpichev Sep 2, 2026
8daf2de
+ comment on test
skirpichev Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4474,12 +4474,14 @@ AC_CACHE_CHECK([for _Float16 support], [ac_cv_float16_supported],
WITH_SAVE_ENV([
CFLAGS="$CFLAGS -O0"
AC_RUN_IFELSE([AC_LANG_SOURCE([[
#include <math.h>
int main(void)
{
_Float16 val = 1.0f16;
int test = !isfinite(val) || isinf(val) || isnan(val);

@vstinner vstinner Sep 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete # Check for native half-float type (_Float16). comment to explain why you test these function calls. Something like:

# Check for native half-float type (_Float16).
# Check also for isinf(_Float16): it's not supported on FreeBSD 15.

double d = 3.14;
val = d;
return 0;
return test;
}
]])], [ac_cv_float16_supported=yes],
[ac_cv_float16_supported=no],
Expand Down
Loading