Repository navigation
gh-156774: Speed up pdb startup with asyncio guard #156775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3c199f4
gh-999998: Speed up pdb startup with lazy imports
brittanyrey 8d15fb1
gh-156774: Point pdb lazy-import NEWS entry at the filed issue
brittanyrey 89fccc3
gh-156774: Scope pdb change down to the asyncio import only
brittanyrey 5ad79b2
Address comments
brittanyrey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-156774: Scope pdb change down to the asyncio import only
Drop the other lazy imports and the lifted function-level imports, leaving just the asyncio deferral and the _get_asyncio_task() guard. Those two carry most of the win and keep the diff to five lines. import pdb -28.8% (was -42.1% with the full set) breakpoint() -> cont -28.5% python -m pdb script -26.0% pdb post-mortem -24.6%
- Loading branch information
commit 89fccc3c5ec5047a0a9f7d1aa16883cb7958c5ff
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
Misc/NEWS.d/next/Library/2026-08-31-11-40-00.gh-issue-156774.Pd8Lz1.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| Speed up :mod:`pdb` startup by about 40% using :keyword:`lazy import`, and by | ||
| skipping the :mod:`asyncio` import when no event loop has been used. | ||
| Speed up :mod:`pdb` startup by deferring the :mod:`asyncio` import, and by | ||
| skipping it entirely in ``Pdb._get_asyncio_task()`` when no event loop has | ||
| been used. | ||
|
brittanyrey marked this conversation as resolved.
Outdated
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.