Skip to content

gh-153569: return token spans and unify decoded source storage #156482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 6 commits into from
Sep 6, 2026
Merged

gh-153569: return token spans and unify decoded source storage #156482

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44ef2d1
gh-153569: bound tokenizer input storage
pablogsal Aug 30, 2026
f381082
gh-153569: return tokenizer tokens as source spans
pablogsal Aug 30, 2026
b60cc04
gh-153569: enforce tokenizer buffer view lifetimes
pablogsal Sep 5, 2026
2bdef78
gh-153569: Unify decoded tokenizer storage ownership
pablogsal Sep 5, 2026
27c3d73
gh-153569: Avoid overflow when sizing implicit line flags
pablogsal Sep 5, 2026
6117ae3
Remove stale tokenizer buffer ownership comment
pablogsal Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-153569: Avoid overflow when sizing implicit line flags
  • Loading branch information
@pablogsal
pablogsal committed Sep 5, 2026
commit 27c3d732c3d375d9d133782038984b2da7647da7
7 changes: 3 additions & 4 deletions Parser/tokenizer/source.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ _PyTok_SourceDiscard(_PyTok_SourceText *source)
source->bytes[0] = '\0';
}
if (source->implicit_lines != NULL) {
memset(source->implicit_lines, 0,
Py_MIN(((Py_ssize_t)source->nlines + 7) / 8,
source->implicit_cap));
Py_ssize_t used = source->nlines / 8 + (source->nlines % 8 != 0);
memset(source->implicit_lines, 0, Py_MIN(used, source->implicit_cap));
}
source->nlines = 0;
}
Expand Down Expand Up @@ -106,7 +105,7 @@ reserve_checkpoints(_PyTok_SourceText *source, int needed)
static int
reserve_implicit_lines(_PyTok_SourceText *source, int nlines)
{
Py_ssize_t needed = ((Py_ssize_t)nlines + 7) / 8;
Py_ssize_t needed = nlines / 8 + (nlines % 8 != 0);
if (needed <= source->implicit_cap) {
return 0;
}
Expand Down