Skip to content

gh-82150: Make urllib.parse.urlsplit and urllib.parse.urlunsplit preserve the '?' and '#' delimiters of empty query and fragment components #15642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geryogam wants to merge 19 commits into from
Closed

gh-82150: Make urllib.parse.urlsplit and urllib.parse.urlunsplit preserve the '?' and '#' delimiters of empty query and fragment components #15642

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
838e934
Update parse.py
geryogam Sep 2, 2019
8bffcf3
Update parse.py
geryogam Sep 2, 2019
e7e1f7a
Update urllib.parse.rst
geryogam Sep 2, 2019
050de62
Update parse.py
geryogam Sep 2, 2019
4df550d
Update parse.py
geryogam Sep 2, 2019
2dfecf2
Update test_urllib2.py
geryogam Sep 2, 2019
98d25e7
Update test_urlparse.py
geryogam Sep 2, 2019
a56112a
Update test_urlparse.py
geryogam Sep 2, 2019
7dc5a12
Update test_urlparse.py
geryogam Sep 2, 2019
ad3994a
Update parse.py
geryogam Sep 2, 2019
6d70b49
Update test_urlparse.py
geryogam Sep 2, 2019
58947a5
Update test_urlparse.py
geryogam Sep 2, 2019
db39e96
Update test_urlparse.py
geryogam Sep 2, 2019
67465d2
Update test_urlparse.py
geryogam Sep 2, 2019
d6bd27f
Create 2019-09-10-17-01-35.bpo-37969.5Dz8e7.rst
geryogam Sep 10, 2019
8158fc2
Merge branch 'master' into patch-8
geryogam Mar 6, 2021
f6a8466
Merge branch 'main' into patch-8
geryogam Dec 1, 2022
2c8a286
Use RFC 3986 terminology (‘undefined’)
geryogam Dec 2, 2022
8183cf7
Update doc tests
geryogam Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update parse.py
  • Loading branch information
@geryogam
geryogam authored Sep 2, 2019
commit 050de62ef6b9e74315768af5c5e21c433642553f
3 changes: 2 additions & 1 deletion Lib/urllib/parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,8 @@ def urlsplit(url, scheme='', allow_fragments=True):
return _coerce_result(cached)
if len(_parse_cache) >= MAX_CACHE_SIZE: # avoid runaway growth
clear_cache()
netloc = query = fragment = None # no components NOR DELIMITERS
netloc = ''
query = fragment = None # no components NOR DELIMITERS
i = url.find(':')
if i > 0:
if url[:i] == 'http': # optimize the common case
Expand Down