Skip to content

gh-155496: Use Argument Clinic for more functions in the time module #155513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 8 commits into from
Sep 21, 2026
Merged

gh-155496: Use Argument Clinic for more functions in the time module #155513

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01086a8
gh-155496: Use Argument Clinic for more functions of the time module
serhiy-storchaka Aug 10, 2026
ed893d6
Update test_inspect for the new signatures
serhiy-storchaka Aug 13, 2026
4108372
Fix test_autospec_on_bound_builtin_function
serhiy-storchaka Aug 13, 2026
ca3e771
Use a function which is defined without a signature
serhiy-storchaka Aug 13, 2026
b10998e
Address review comments
serhiy-storchaka Aug 14, 2026
fa2f855
Merge remote-tracking branch 'upstream/main' into time-clinic
serhiy-storchaka Aug 14, 2026
5c437c2
Fix the summary/body split in the tzset() docstring
serhiy-storchaka Aug 27, 2026
37b1621
Merge remote-tracking branch 'upstream/main' into time-clinic
serhiy-storchaka Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use a function which is defined without a signature 
Any builtin function can get a signature, therefore the test uses the
function which exists for testing the lack of it.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Aug 13, 2026
commit ca3e77105aa9b1da1f988a87a1ec42d8d55edfeb
9 changes: 6 additions & 3 deletions Lib/test/test_unittest/testmock/testhelpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
import types
import unittest

from test.support import import_helper

from unittest.mock import (
call, _Call, create_autospec, MagicMock,
Mock, ANY, _CallList, patch, PropertyMock, _callable
Expand Down Expand Up @@ -928,9 +930,10 @@ def check_data_descriptor(mock_attr):


def test_autospec_on_bound_builtin_function(self):
# max() is variadic, therefore it has no signature.
meth = types.MethodType(max, [4, 5, 6])
self.assertEqual(meth(), 6)
_testcapi = import_helper.import_module('_testcapi')
# This function is defined without a signature.
meth = types.MethodType(_testcapi.docstring_no_signature, object())
self.assertIsNone(meth())
mocked = create_autospec(meth)

# no signature, so no spec to check against
Expand Down
Loading