Skip to content

gh-155278: Avoid needlessly accessing ForwardRef.__forward_code__ in evaluate_forward_ref() #155279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 2 commits into from
Aug 7, 2026
Merged

gh-155278: Avoid needlessly accessing ForwardRef.__forward_code__ in evaluate_forward_ref() #155279

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24e985d
gh-155278: Avoid needlessly accessing `ForwardRef.__forward_code__` i…
Viicos Aug 6, 2026
ca262b1
Apply suggestion from @Viicos
Viicos Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import collections.abc
import copyreg
import functools
import keyword
import operator
import sys
import types
Expand Down Expand Up @@ -998,8 +999,12 @@ def _make_forward_ref(code, *, parent_fwdref=None, **kwargs):
if parent_fwdref.__owner__ is not None:
kwargs['owner'] = parent_fwdref.__owner__
forward_ref = annotationlib.ForwardRef(code, **kwargs)
# For compatibility, eagerly compile the forwardref's code.
forward_ref.__forward_code__
# For compatibility, eagerly compile the forwardref's code so that any
# SyntaxError is raised immediately rather than when the forward
# reference is evaluated. Similar to 'ForwardRef.evaluate(), we only compile
Comment thread
Viicos marked this conversation as resolved.
Outdated
# it if necessary:
if not (code.isidentifier() and not keyword.iskeyword(code)):
forward_ref.__forward_code__
return forward_ref


Expand Down
Loading