Skip to content

gh-154726: Fix shutil.copyfile() for symlinks to special files with follow_symlinks=False #154728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 4 commits into from
Jul 31, 2026
Merged

gh-154726: Fix shutil.copyfile() for symlinks to special files with follow_symlinks=False #154728

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1451551
gh-154726: Fix `shutil.copyfile()` for device symlinks with `follow_s…
lkk7 Jul 26, 2026
88fa4c7
gh-154726: Test FIFO and socket symlinks in `shutil.copyfile()`
lkk7 Jul 27, 2026
2fb2134
gh-154726: Match socket bind error handling in shutil tests
lkk7 Jul 27, 2026
bf7e3d2
gh-154726: Group shutil special-file symlink tests
lkk7 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-154726: Match socket bind error handling in shutil tests
  • Loading branch information
@lkk7
lkk7 committed Jul 27, 2026
commit 2fb2134bf7ce429c2eaf9389b9064cf12c8ce71a
7 changes: 1 addition & 6 deletions Lib/test/test_shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1606,12 +1606,7 @@ def test_copyfile_symlink_to_socket(self):
try:
socket_helper.bind_unix_socket(sock, sock_path)
except OSError as e:
if str(e) == "AF_UNIX path too long":
self.skipTest(
"Pathname {0!a} is too long to serve as an AF_UNIX path"
.format(sock_path))
else:
raise
self.skipTest(f'cannot bind AF_UNIX socket: {e}')
self.addCleanup(os_helper.unlink, sock_path)
self._check_copyfile_symlink_to_special_file(sock_path)

Expand Down