Skip to content

gh-129069: fix TSAN-0013 from gh-153852 #154516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xxyzz wants to merge 2 commits into from
Closed

gh-129069: fix TSAN-0013 from gh-153852 #154516

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb9567a
gh-129069: use atomic read in `_Py_SIZE_impl()`
xxyzz Jul 22, 2026
786ad9f
gh-129069: use atomic `_PyList_GetItemRef` in `stringlib_bytes_join`
xxyzz Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
gh-129069: use atomic _PyList_GetItemRef in stringlib_bytes_join 
part of TSAN-0013 in gh-153852
  • Loading branch information
@xxyzz
xxyzz committed Jul 23, 2026
commit 786ad9f8418fc216aac1e52aeffeab0157005dff
1 change: 1 addition & 0 deletions Objects/bytearrayobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "pycore_object.h" // _PyObject_GC_UNTRACK()
#include "pycore_strhex.h" // _Py_strhex_with_sep()
#include "pycore_long.h" // _PyLong_FromUnsignedChar()
#include "pycore_list.h" // _PyList_GetItemRef
#include "pycore_pyatomic_ft_wrappers.h"
#include "bytesobject.h"

Expand Down
9 changes: 9 additions & 0 deletions Objects/stringlib/join.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,16 @@ STRINGLIB(bytes_join)(PyObject *sep, PyObject *iterable)
*/
for (i = 0, nbufs = 0; i < seqlen; i++) {
Py_ssize_t itemlen;
#ifdef Py_GIL_DISABLED
if (PyList_Check(seq)) {
item = _PyList_GetItemRef((PyListObject *)seq, i);

@ambv ambv Oct 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a new reference and leaks (below the refcount is additionally increased in :75 or :82).

test_bytes -R 3:3 fails on this.

}
else {
item = PyTuple_GET_ITEM(seq, i);
}
#else
item = PySequence_Fast_GET_ITEM(seq, i);
#endif
if (PyBytes_CheckExact(item)) {
/* Fast path. */
buffers[i].obj = Py_NewRef(item);
Expand Down
Loading