Skip to content

gh-154387: Fix structseq_repr mislabeling of unnamed PyStructSequence fields #154434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pranavchoudhary-tech wants to merge 9 commits into from
Closed

gh-154387: Fix structseq_repr mislabeling of unnamed PyStructSequence fields #154434

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6f010d0
docs: clarify custom build output directory in PCbuild/readme.txt
pranavchoudhary-tech Jul 9, 2026
757f9d3
docs: add news entry for 118860
pranavchoudhary-tech Jul 9, 2026
d2c81d9
Apply reviewer feedback
pranavchoudhary-tech Jul 9, 2026
1f573ad
Apply text wrapping and environment variable suggestion
pranavchoudhary-tech Jul 9, 2026
c587424
Apply review feedback from zooba
pranavchoudhary-tech Jul 21, 2026
7eb8c27
Trigger CI to bypass flaky test_tkinter failure
pranavchoudhary-tech Jul 21, 2026
52c00eb
Fix structseq_repr indexing to prevent unnamed fields mislabeling
pranavchoudhary-tech Jul 22, 2026
d94858c
Add news entry for structseq_repr bug fix
pranavchoudhary-tech Jul 22, 2026
98f8f34
Revert unrelated change to PCbuild/readme.txt
pranavchoudhary-tech Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert unrelated change to PCbuild/readme.txt
  • Loading branch information
@pranavchoudhary-tech
pranavchoudhary-tech committed Jul 22, 2026
commit 98f8f343fe57fc01a0d3ee991c77198fbd3c294f
33 changes: 2 additions & 31 deletions PCbuild/readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ external dependencies. To build, simply run the "build.bat" script without
any arguments. After this succeeds, you can open the "pcbuild.sln"
solution in Visual Studio to continue development.

To build an installer package, refer to the README in the Tools/msi folder.
To build an installer package, refer to PC/layout.

The solution currently supports two platforms. The Win32 platform is
used to build standard x86-compatible 32-bit binaries, output into the
Expand Down Expand Up @@ -105,25 +105,6 @@ the 32-bit Win32 platform. It accepts several arguments to change
this behavior, try `build.bat -h` to learn more.

@picnixz picnixz Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated changes please delete this.



Custom Output Directory
-----------------------

If you want to move the build outputs to a different directory, use the
`Py_OutDir` property either as a standard MSBuild `/p:Py_OutDir=` argument
(for example, `build.bat "/p:Py_OutDir=C:\MyOutput"`) or an environment
variable. Using the standard MSBuild `/p:OutDir=` property will more
directly override the output location, which may result in a broken build.

However, be aware that the compiled binaries probably won't run directly from
that location. If you want to make an install-shaped layout without creating the
installer, build CPython normally first, and then use the `PC/layout` script
with the runtime you just built, or using the `--build` and `--source` options
to specify the directories:
python.bat PC/layout --<options>
Use `-h` with that command to see all available options for customizing the
layout.


C Runtime
---------

Expand Down Expand Up @@ -159,12 +140,6 @@ CPython in different ways:
pythonw
pythonw.exe, a variant of python.exe that doesn't open a Command
Prompt window
pylauncher
py.exe, the Python Launcher for Windows, see
https://docs.python.org/3/using/windows.html#launcher
pywlauncher
pyw.exe, a variant of py.exe that doesn't open a Command Prompt
window
_testembed
_testembed.exe, a small program that embeds Python for testing
purposes, used by test_capi.py
Expand All @@ -175,8 +150,6 @@ _freeze_module
_freeze_module.exe, used to regenerate frozen modules in Python
after changes have been made to the corresponding source files
(e.g. Lib\importlib\_bootstrap.py).
pyshellext
pyshellext.dll, the shell extension deployed with the launcher
python3dll
python3.dll, the PEP 384 Stable ABI dll
(not installed on free-threaded builds)
Expand Down Expand Up @@ -266,7 +239,7 @@ _sqlite3
https://www.sqlite.org/

_tkinter
Wraps version 9.0.3 of the Tk windowing system, which is downloaded
Wraps version 9.0.4 of the Tk windowing system, which is downloaded
from our binaries repository at
https://github.com/python/cpython-bin-deps.

Expand Down Expand Up @@ -439,8 +412,6 @@ _testclinic_limited extension, the file Modules/_testclinic_limited.c:
* Save and exit Visual Studio.
* Add `;_testclinic_limited` to `<TestModules Include="...">` in
PCbuild\pcbuild.proj.
* Update "exts" in Tools\msi\lib\lib_files.wxs file or in
Tools\msi\test\test_files.wxs file (for tests).
* PC\layout\main.py needs updating if you add a test-only extension whose name
doesn't start with "_test".
* Add the extension to PCbuild\readme.txt (this file).
Expand Down
Loading