Skip to content

gh-154194: Degrade frames in Tachyon instead of failing the sample #154195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 13 commits into from
Oct 5, 2026
Merged

gh-154194: Degrade frames in Tachyon instead of failing the sample #154195

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8aaf6f0
degrade gracefully
maurycy Jul 19, 2026
f45ef66
news
maurycy Jul 19, 2026
ad797d5
better NEWS wording
maurycy Jul 21, 2026
3e58d13
do not raise on MAX_REMOTE_STR_READ
maurycy Jul 24, 2026
55632e9
bye MAX_REMOTE_STR_READ
maurycy Jul 24, 2026
6736133
fix -m asyncio ps|pstree
maurycy Jul 24, 2026
17b4197
test truncation and linetable sentinel
maurycy Jul 24, 2026
8213bd3
Merge remote-tracking branch 'upstream/main' into tachyon-degrade-gra…
maurycy Sep 25, 2026
443f5c1
simpler
maurycy Oct 4, 2026
bb28257
simpler
maurycy Oct 4, 2026
be34b1f
redundant now
maurycy Oct 4, 2026
2a88472
respect #157790 in the news
maurycy Oct 4, 2026
c6a44a8
gh-154194: Integrate bounded walks and simplify degradation tests
pablogsal Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
do not raise on MAX_REMOTE_STR_READ
  • Loading branch information
@maurycy
maurycy committed Jul 24, 2026
commit 3e58d13d0617e54bc48365d4456f95df2d6a45b6
4 changes: 3 additions & 1 deletion Modules/_remote_debugging/_remote_debugging.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,10 @@ typedef enum _WIN32_THREADSTATE {
#define SIZEOF_GC_RUNTIME_STATE sizeof(struct _gc_runtime_state)
#define SIZEOF_INTERPRETER_STATE sizeof(PyInterpreterState)

/* Sanity cap for a single string read that are truncated, not rejected. */
#define MAX_REMOTE_STR_READ ((Py_ssize_t)(256 * 1024))

/* Maximum sizes for validation to prevent buffer overflows from corrupted data */
#define MAX_REMOTE_READ ((Py_ssize_t)(256 * 1024)) /* 256 KB max for variable-length object reads */
#define MAX_STACK_CHUNK_SIZE (16 * 1024 * 1024) /* 16 MB max for stack chunks */
#define MAX_LONG_DIGITS 64 /* Allows values up to ~2^1920 */
#define MAX_SET_TABLE_SIZE (1 << 20) /* 1 million entries max for set iteration */
Expand Down
4 changes: 2 additions & 2 deletions Modules/_remote_debugging/object_reading.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ read_py_str(
}

Py_ssize_t len = GET_MEMBER(Py_ssize_t, unicode_obj, unwinder->debug_offsets.unicode_object.length);
if (len < 0 || len > MAX_REMOTE_READ) {
if (len < 0) {
PyErr_Format(PyExc_RuntimeError,
"Invalid string length (%zd) at 0x%lx", len, address);
set_exception_cause(unwinder, PyExc_RuntimeError, "Invalid string length in remote Unicode object");
return NULL;
}
Py_ssize_t read_len = Py_MIN(len, max_len);
Py_ssize_t read_len = Py_MIN(len, Py_MIN(max_len, MAX_REMOTE_STR_READ));
int truncated = read_len != len;

// Inspect state to pick the right data offset and character width.
Expand Down