Repository navigation
Conversation
johng
changed the title
8623456 to
765d7d5
Compare
Obtain a reference to lz->long_cnt, lz->long_step such that we don't hit a use after free
765d7d5 to
8580b6a
Compare
johng
changed the title
|
This appears to add some very slight overhead to repr in slow mode, no impact to the likely more heavily used fast mode |
|
Performances are not really inportant for |
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
@picnixz would you be able to kindly review again, thanks! |
|
@picnixz kindly pining for a re-review, thank you! |
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
It may just seem dumb but since __repr__ is fairly used just for debugging, I don't think we really need to worry about performances; so why not just having everything in a critical section? would that work?
|
Would that not risk locking other threads executing more latency sensitive functions that are holding the lock? |
|
We don't care here IMO. If you print the counter, just expect it to possbly be slow. And can you simply benchmark this please? |
2 participants
Obtain a reference to lz->long_cnt, lz->long_step
such that we don't hit a use after free.