Skip to content

gh-152433: Windows: modernize and refactor fileutils to allow build for Windows UWP #153700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 12 commits into from
Jul 24, 2026
Merged

gh-152433: Windows: modernize and refactor fileutils to allow build for Windows UWP #153700

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
190b3f2
gh-152433: Windows: modernize fileutils to allow build for Windows UWP
thexai Jul 17, 2026
5dabc7c
Simplification 1
thexai Jul 19, 2026
43d4fc2
Full remove of _Py_find_data_to_stat
thexai Jul 21, 2026
003af98
Simplification 2
thexai Jul 21, 2026
a0f6bb7
Fix typo
thexai Jul 21, 2026
9a694a3
Simplification 3: Remove ``GetFileInformationByHandle`` on Desktop
thexai Jul 21, 2026
b81a7d1
Remove unnecessary/accidental changes
thexai Jul 21, 2026
24a0f47
Preserve old code format
thexai Jul 21, 2026
4c18091
Use BASIC_INFO and STANDARD_INFO in ``find_data_to_file_info``
thexai Jul 23, 2026
7221f0c
Full remove of BY_HANDLE_FILE_INFORMATION parameter
thexai Jul 23, 2026
9c7338a
Improve NEWS and cosmetics
thexai Jul 23, 2026
e4e4d5d
Remove st_dev and st_ino fallback values
thexai Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove st_dev and st_ino fallback values
  • Loading branch information
@thexai
thexai committed Jul 24, 2026
commit e4e4d5d55c5daf7f6778b4142f57f150e89fea47
5 changes: 0 additions & 5 deletions Python/fileutils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,11 +1124,6 @@ _Py_attribute_data_to_stat(FILE_STANDARD_INFO* standard_info, ULONG reparse_tag,
file_id.id = id_info->FileId;
result->st_ino = file_id.st_ino;
result->st_ino_high = file_id.st_ino_high;
Comment thread
thexai marked this conversation as resolved.
} else {
// use these fallback values for systems where it's not possible
// to obtain VolumeSerialNumber / FileId (e.g. Windows UWP)
result->st_dev = 1;
result->st_ino = basic_info->CreationTime.QuadPart;
}

result->st_file_attributes = basic_info->FileAttributes;
Expand Down
Loading