Skip to content

gh-149816: fix a race when fetching OpenSSL digests #153019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 6 commits into from
Oct 20, 2026
Merged

gh-149816: fix a race when fetching OpenSSL digests #153019

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f58811f
gh-149816: fix a race when fetching OpenSSL digests
picnixz Jul 4, 2026
dc70859
unconditionally do a CAS
picnixz Jul 6, 2026
8e95250
amend NEWS
picnixz Jul 6, 2026
ae22c22
amend NEWS
picnixz Jul 6, 2026
13d9e17
Merge branch 'main' into fix/free-threading/hashlib-evp-md-149816
picnixz Oct 19, 2026
fd15300
Merge branch 'main' into fix/free-threading/hashlib-evp-md-149816
picnixz Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unconditionally do a CAS
  • Loading branch information
@picnixz
picnixz committed Jul 6, 2026
commit dc7085966c31436ceec50fe2cdeee9eddb8442a2
4 changes: 0 additions & 4 deletions Modules/_hashopenssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,6 @@ get_openssl_evp_md_by_utf8name(_hashlibstate *state, const char *name,
* See https://github.com/python/cpython/issues/128657
* and https://github.com/python/cpython/issues/149816.
*/
#ifdef Py_GIL_DISABLED
PY_EVP_MD *expected = NULL;
if (_Py_atomic_compare_exchange_ptr(cached, &expected, (void *)fresh)) {
digest = fresh; // we won: 'cached' now owns the fresh digest
Expand All @@ -721,9 +720,6 @@ get_openssl_evp_md_by_utf8name(_hashlibstate *state, const char *name,
PY_EVP_MD_free(fresh); // we lost: discard the fresh digest
digest = expected; // reuse the winner's digest
}
#else
digest = *cached = fresh;
#endif
}
}
/* Hand the caller its own reference; the cache keeps its own. Valid
Expand Down