Skip to content

bpo-11671: add header validation from http.client to wsgiref.headers.Headers #15299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
epicfaace wants to merge 8 commits into from
Closed

bpo-11671: add header validation from http.client to wsgiref.headers.Headers #15299

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
221779a
apply devin's patch from bpo-11671
epicfaace Aug 15, 2019
501ac89
spacing
epicfaace Aug 15, 2019
6928b31
fix: use regex's from http.client to validate header names and values…
epicfaace Aug 15, 2019
6cd271a
test: update tests to be more consistent with http.client tests
epicfaace Aug 15, 2019
8446cfd
use add_header in constructor
epicfaace Aug 19, 2019
71d5819
test: test invalid types
epicfaace Aug 19, 2019
d172a8e
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 27, 2019
db98184
Update 2019-08-27-01-08-25.bpo-11671.wfJY-D.rst
epicfaace Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use add_header in constructor
  • Loading branch information
@epicfaace
epicfaace committed Aug 19, 2019
commit 8446cfd006a20f429d97da4ccbc24a48b83a7404
7 changes: 2 additions & 5 deletions Lib/wsgiref/headers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,9 @@ def __init__(self, headers=None):
headers = headers if headers is not None else []
if type(headers) is not list:
raise TypeError("Headers must be a list of name/value tuples")
self._headers = []
for header, value in headers:
if not _is_legal_header_name(header.encode('ascii')):
raise ValueError('Invalid header name %r' % (header,))
if _is_illegal_header_value(value.encode('ascii')):
raise ValueError('Invalid header value %r' % (value,))
self._headers = headers
self.add_header(header, value)
if __debug__:
for k, v in headers:
self._convert_string_type(k)
Expand Down