Skip to content

gh-151292: _remote_debugging: Do not corrupt the binary file when hitting OverflowError #152892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 8 commits into from
Oct 5, 2026
Merged

gh-151292: _remote_debugging: Do not corrupt the binary file when hitting OverflowError #152892

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d785cbf
the kolektor
maurycy Jul 2, 2026
2e714c5
test
maurycy Jul 2, 2026
26109d0
better test
maurycy Jul 2, 2026
361b0d1
news
maurycy Jul 2, 2026
aecf40d
Merge branch 'main' into graceful-binary-overflow
maurycy Aug 16, 2026
1231afe
=Q, move const to the base, not self.running
maurycy Aug 16, 2026
5057295
Merge branch 'main' into graceful-binary-overflow
maurycy Oct 4, 2026
9de4476
gh-151292: Track binary writer finalization state
pablogsal Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better test
  • Loading branch information
@maurycy
maurycy committed Jul 11, 2026
commit 26109d0e44a0b038cf675fcb7fe0cf0db937a5ba
9 changes: 9 additions & 0 deletions Lib/test/test_profiling/test_sampling_profiler/test_binary_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,15 @@ def write_sample(self, stack_frames, timestamp_us):
# keeps the samples collected before the limit was hit.
collector._writer = real_writer
collector.export(None)

with open(filename, "rb") as f:
header = f.read(32)
magic, version = struct.unpack_from("=II", header, 0)
self.assertEqual(magic, 0x54414348) # "TACH"
self.assertEqual(version, 1)
(sample_count,) = struct.unpack_from("=I", header, 28)

@pablogsal pablogsal Aug 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

total_samples is a u64 in the header (HDR_SIZE_SAMPLES is 8), so "=I" here only reads half of it. On big-endian (the s390x buildbots) this reads the high word and the assert will fail. Can we read 64 bytes and unpack with "=Q"? btw TestBinaryFormatValidation below already has HDR_OFF_SAMPLES = 28, maybe we can reuse it.

@maurycy maurycy Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablogsal Definitely. Thank you for catching this. Sorry for not updating the PR immediately after merging #153425.

Changed to =Q and moved HDR_OFF_SAMPLES, and other consts, to BinaryFormatTestBase in 1231afe

I ack there's still #152892 (comment) pending

Comment thread
maurycy marked this conversation as resolved.
Outdated
self.assertEqual(sample_count, 3)

reader_collector = RawCollector()
with BinaryReader(filename) as reader:
self.assertEqual(reader.replay_samples(reader_collector), 3)
Expand Down