Skip to content

gh-152721: Fix quadratic RLE replay time in the profiling binary reader #152722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 7 commits into from
Oct 5, 2026
Merged

gh-152721: Fix quadratic RLE replay time in the profiling binary reader #152722

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1dac106
gh-152721: Fix quadratic RLE replay time in the profiling binary reader
tonghuaroot Jul 1, 2026
beb5980
gh-152721: Clarify the batch-list comment
tonghuaroot Jul 2, 2026
3e71061
Cap RLE batch size to bound the per-batch timestamp list
tonghuaroot Jul 2, 2026
6594318
Move MAX_RLE_BATCH_SAMPLES comment to its own line (keep under 79 cols)
tonghuaroot Jul 2, 2026
70a2e41
Drop the now-redundant emit_batch trim and fix the review nits
tonghuaroot Aug 18, 2026
8836caa
Merge remote-tracking branch 'upstream/main' into tachyon-land-152722
pablogsal Oct 5, 2026
e3327f5
gh-152721: Test replay batches beyond the RLE limit
pablogsal Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cap RLE batch size to bound the per-batch timestamp list
  • Loading branch information
@tonghuaroot
tonghuaroot committed Jul 2, 2026
commit 3e71061c1728f3b9093239f4e071037c79a97d7b
4 changes: 3 additions & 1 deletion Modules/_remote_debugging/binary_io_reader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

/* Progress callback frequency */
#define PROGRESS_CALLBACK_INTERVAL 1000
#define MAX_RLE_BATCH_SAMPLES 8192 /* Cap per-batch samples to bound the timestamp list (gh-152089) */

/* ============================================================================
* BINARY READER IMPLEMENTATION
Expand Down Expand Up @@ -1095,7 +1096,8 @@ binary_reader_replay(BinaryReader *reader, PyObject *collector, PyObject *progre
ts->prev_timestamp += delta;

/* Start new batch on first sample or status change */
if (i == 0 || status != batch_status) {
if (i == 0 || status != batch_status
|| batch_idx >= MAX_RLE_BATCH_SAMPLES) {
Comment thread
pablogsal marked this conversation as resolved.
if (timestamps_list) {
int rc = emit_batch(state, collector, thread_id, interpreter_id,
batch_status, ts->current_stack, ts->current_stack_depth,
Expand Down
Loading