Skip to content

gh-98894: Check readelf failures in test_dtrace #152345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Jul 2, 2026
Merged

gh-98894: Check readelf failures in test_dtrace #152345

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3555323
gh-98894: Check readelf failures in test_dtrace
stratakis Jun 26, 2026
3372f7c
Create a helper for readelf checking shared code
stratakis Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-98894: Check readelf failures in test_dtrace 
Report readelf command failures directly instead of later failing with
missing-probe assertions.
  • Loading branch information
@stratakis
stratakis committed Jun 26, 2026
commit 3555323c72bb9275fb64f312f707cdc3102cd877
14 changes: 11 additions & 3 deletions Lib/test/test_dtrace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ def get_readelf_version():
version, stderr = proc.communicate()

if proc.returncode:
raise Exception(
raise AssertionError(
f"Command {' '.join(cmd)!r} failed "
f"with exit code {proc.returncode}: "
f"stdout={version!r} stderr={stderr!r}"
Expand Down Expand Up @@ -464,13 +464,21 @@ def get_readelf_output(self):
command = ["readelf", "-n", binary]
# Force the C locale to disable localization.
env = dict(os.environ, LC_ALL="C")
stdout, _ = subprocess.Popen(
proc = subprocess.Popen(
command,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
universal_newlines=True,
env=env,
).communicate()
)
with proc:
stdout, _ = proc.communicate()

if proc.returncode:
raise AssertionError(
f"Command {' '.join(command)!r} failed "
f"with exit code {proc.returncode}: stdout={stdout!r}"
)
return stdout

def test_check_probes(self):
Expand Down
Loading