Skip to content

gh-121249: Deprecate using F/D type codes in the struct module #152309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 6 commits into from
Jun 30, 2026
Merged

gh-121249: Deprecate using F/D type codes in the struct module #152309

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ca0a71
gh-121249: Deprecate using F/D type codes in the struct module
skirpichev Jun 26, 2026
c5b52c0
adjust test
skirpichev Jun 26, 2026
f2e3f8e
+1
skirpichev Jun 27, 2026
87d0ea7
Apply suggestions from code review
skirpichev Jun 30, 2026
a2c5ff8
address review
skirpichev Jun 30, 2026
236dab3
+1
skirpichev Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
+1
  • Loading branch information
@skirpichev
skirpichev committed Jun 27, 2026
commit f2e3f8e3997469c62a1d7bef9912285866cf4b66
12 changes: 6 additions & 6 deletions Lib/test/test_ctypes/test_byteswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,14 +178,14 @@ def test_endian_float_complex(self):
self.assertIs(c_float_complex.__ctype_le__.__ctype_be__,
c_float_complex)
s = c_float_complex(math.pi+1j)
self.assertEqual(bin(struct.pack("F", math.pi+1j)), bin(s))
self.assertEqual(bin(struct.pack("Zf", math.pi+1j)), bin(s))
self.assertAlmostEqual(s.value, math.pi+1j, places=6)
s = c_float_complex.__ctype_le__(math.pi+1j)
self.assertAlmostEqual(s.value, math.pi+1j, places=6)
self.assertEqual(bin(struct.pack("<F", math.pi+1j)), bin(s))
self.assertEqual(bin(struct.pack("<Zf", math.pi+1j)), bin(s))
s = c_float_complex.__ctype_be__(math.pi+1j)
self.assertAlmostEqual(s.value, math.pi+1j, places=6)
self.assertEqual(bin(struct.pack(">F", math.pi+1j)), bin(s))
self.assertEqual(bin(struct.pack(">Zf", math.pi+1j)), bin(s))

@unittest.skipUnless(hasattr(ctypes, 'c_double_complex'), "No complex types")
def test_endian_double_complex(self):
Expand All @@ -199,14 +199,14 @@ def test_endian_double_complex(self):
self.assertIs(c_double_complex.__ctype_le__.__ctype_be__,
c_double_complex)
s = c_double_complex(math.pi+1j)
self.assertEqual(bin(struct.pack("D", math.pi+1j)), bin(s))
self.assertEqual(bin(struct.pack("Zd", math.pi+1j)), bin(s))
self.assertAlmostEqual(s.value, math.pi+1j, places=6)
s = c_double_complex.__ctype_le__(math.pi+1j)
self.assertAlmostEqual(s.value, math.pi+1j, places=6)
self.assertEqual(bin(struct.pack("<D", math.pi+1j)), bin(s))
self.assertEqual(bin(struct.pack("<Zd", math.pi+1j)), bin(s))
s = c_double_complex.__ctype_be__(math.pi+1j)
self.assertAlmostEqual(s.value, math.pi+1j, places=6)
self.assertEqual(bin(struct.pack(">D", math.pi+1j)), bin(s))
self.assertEqual(bin(struct.pack(">Zd", math.pi+1j)), bin(s))

def test_endian_other(self):
self.assertIs(c_byte.__ctype_le__, c_byte)
Expand Down
Loading