Skip to content

bpo-38110: Use fdwalk for os.closerange() when available. #15224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 3 commits into from
Sep 11, 2019
Merged

bpo-38110: Use fdwalk for os.closerange() when available. #15224

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f6ec8d
Add fdwalk functionality
kulikjak Aug 12, 2019
e024cc7
Add NEWS entry.
gpshead Sep 11, 2019
f435386
Use PY_MAX(fd_low, 0) as the existing code does.
gpshead Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use PY_MAX(fd_low, 0) as the existing code does.
  • Loading branch information
@gpshead
gpshead authored Sep 11, 2019
commit f435386a86a35a87f98f75de5f1068a9574c18bd
2 changes: 1 addition & 1 deletion Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8420,7 +8420,7 @@ os_closerange_impl(PyObject *module, int fd_low, int fd_high)
Py_BEGIN_ALLOW_THREADS
_Py_BEGIN_SUPPRESS_IPH
#ifdef HAVE_FDWALK
lohi[0] = fd_low;
lohi[0] = Py_MAX(fd_low, 0);
lohi[1] = fd_high;
fdwalk(_fdwalk_close_func, lohi);
#else
Expand Down